public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
	akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
	josh@joshtriplett.org, dvhltc@us.ibm.com, niv@us.ibm.com,
	tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org,
	Valdis.Kletnieks@vt.edu, dhowells@redhat.com, avi@redhat.com,
	mtosatti@redhat.com,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH tip/core/rcu 5/6] rcu: Improve rcutorture diagnostics when bad torture_type specified
Date: Sun, 25 Oct 2009 19:03:54 -0700	[thread overview]
Message-ID: <12565226351868-git-send-email-> (raw)
In-Reply-To: <20091026020253.GA11350@linux.vnet.ibm.com>

From: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Make rcutorture list the available torture_type values when it doesn't
like the one specified.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---
 kernel/rcutorture.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
index 14480e8..3dd0ca2 100644
--- a/kernel/rcutorture.c
+++ b/kernel/rcutorture.c
@@ -1129,8 +1129,12 @@ rcu_torture_init(void)
 			break;
 	}
 	if (i == ARRAY_SIZE(torture_ops)) {
-		printk(KERN_ALERT "rcutorture: invalid torture type: \"%s\"\n",
+		printk(KERN_ALERT "rcu-torture: invalid torture type: \"%s\"\n",
 		       torture_type);
+		printk(KERN_ALERT "rcu-torture types:");
+		for (i = 0; i < ARRAY_SIZE(torture_ops); i++)
+			printk(KERN_ALERT " %s", torture_ops[i]->name);
+		printk(KERN_ALERT "\n");
 		mutex_unlock(&fullstop_mutex);
 		return -EINVAL;
 	}
-- 
1.5.2.5


  parent reply	other threads:[~2009-10-26  2:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-26  2:02 [PATCH tip/core/rcu 0/6] rcu: Tiny RCU, expedited RCU, rcutorture fixes, lockdep simplification Paul E. McKenney
2009-10-26  2:03 ` [PATCH tip/core/rcu 1/6] rcu: The Bloatwatch Edition, v8 Paul E. McKenney
2009-10-26 11:36   ` [tip:core/rcu] rcu: "Tiny RCU", The Bloatwatch Edition tip-bot for Paul E. McKenney
2009-10-26 11:37   ` [tip:core/rcu] rcu: Do tiny cleanups in rcutiny tip-bot for Ingo Molnar
2009-10-26 16:29     ` Paul E. McKenney
2009-10-26  2:03 ` [PATCH tip/core/rcu 2/6] rcu: Add synchronize_srcu_expedited() Paul E. McKenney
2009-10-26 11:36   ` [tip:core/rcu] " tip-bot for Paul E. McKenney
2009-10-26  2:03 ` [PATCH tip/core/rcu 3/6] rcu: add synchronize_srcu_expedited() to the rcutorture test suite Paul E. McKenney
2009-10-26 11:37   ` [tip:core/rcu] rcu: Add " tip-bot for Paul E. McKenney
2009-10-26  2:03 ` [PATCH tip/core/rcu 4/6] rcu: add synchronize_srcu_expedited() to the documentation Paul E. McKenney
2009-10-26 11:37   ` [tip:core/rcu] rcu: Add " tip-bot for Paul E. McKenney
2009-10-26  2:03 ` Paul E. McKenney [this message]
2009-10-26 11:37   ` [tip:core/rcu] rcu: Improve rcutorture diagnostics when bad torture_type specified tip-bot for Paul E. McKenney
2009-10-26  2:03 ` [PATCH tip/core/rcu 6/6] rcu: Simplify creating of lockdep class for root rcu_node Paul E. McKenney
2009-10-26  6:50   ` Ingo Molnar
2009-10-26 17:13     ` Paul E. McKenney
2009-10-26  8:34   ` Lai Jiangshan
2009-10-26 17:12     ` Paul E. McKenney
2009-10-26  2:27 ` [PATCH tip/core/rcu 0/6] rcu: Tiny RCU, expedited RCU, rcutorture fixes, lockdep simplification Josh Triplett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12565226351868-git-send-email- \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=avi@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=dipankar@in.ibm.com \
    --cc=dvhltc@us.ibm.com \
    --cc=josh@joshtriplett.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mingo@elte.hu \
    --cc=mtosatti@redhat.com \
    --cc=niv@us.ibm.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox