From: <gregkh@suse.de>
To: stsp@aknet.ru, gregkh@suse.de, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: patch driver-core-fix-driver_register-return-value.patch added to gregkh-2.6 tree
Date: Mon, 26 Oct 2009 16:56:58 -0700 [thread overview]
Message-ID: <12566014181853@kroah.org> (raw)
In-Reply-To: <4ADA29AA.9070907@aknet.ru>
This is a note to let you know that I've just added the patch titled
Subject: Driver core: fix driver_register() return value
to my gregkh-2.6 tree. Its filename is
driver-core-fix-driver_register-return-value.patch
This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
>From stsp@aknet.ru Mon Oct 26 16:00:03 2009
From: Stas Sergeev <stsp@aknet.ru>
Date: Sun, 18 Oct 2009 00:31:38 +0400
Subject: Driver core: fix driver_register() return value
To: Greg KH <gregkh@suse.de>
Cc: Linux kernel <linux-kernel@vger.kernel.org>
Message-ID: <4ADA29AA.9070907@aknet.ru>
In this patch:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=16dc42e018c2868211b4928f20a957c0c216126c
the check was added for another driver to already claim the same device
on the same bus. But the returned error code was wrong: to modprobe, the
-EEXIST means that _this_ driver is already installed. It therefore
doesn't produce the needed error message when _another_ driver is trying
to register for the same device. Returning -EBUSY fixes the problem.
Signed-off-by: Stas Sergeev <stsp@aknet.ru>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/base/driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/base/driver.c
+++ b/drivers/base/driver.c
@@ -236,7 +236,7 @@ int driver_register(struct device_driver
put_driver(other);
printk(KERN_ERR "Error: Driver '%s' is already registered, "
"aborting...\n", drv->name);
- return -EEXIST;
+ return -EBUSY;
}
ret = bus_add_driver(drv);
prev parent reply other threads:[~2009-10-27 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-17 20:31 [patch] fix driver_register() return value Stas Sergeev
2009-10-17 20:46 ` Greg KH
2009-10-17 21:03 ` Stas Sergeev
2009-10-26 23:56 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12566014181853@kroah.org \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=stsp@aknet.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox