public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Safford <safford@watson.ibm.com>
To: Eric Paris <eparis@redhat.com>
Cc: Eric Paris <eparis@parisplace.org>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, James Morris <jmorris@namei.org>,
	Rajiv Andrade <srajiv@linux.vnet.ibm.com>,
	Jean-Christophe Dubois <jcd@tribudubois.net>,
	Mimi Zohar <zohar@us.ibm.com>, Stable Kernel <stable@kernel.org>
Subject: Re: [PATCH] ima: remove ACPI dependency
Date: Tue, 27 Oct 2009 16:42:07 -0400	[thread overview]
Message-ID: <1256676127.3028.86.camel@localhost.localdomain> (raw)
In-Reply-To: <1256661407.2804.15.camel@dhcp231-106.rdu.redhat.com>

On Tue, 2009-10-27 at 12:36 -0400, Eric Paris wrote:
> On Tue, 2009-10-27 at 11:59 -0400, David Safford wrote:
> > Basically, if running on a system with a TPM, IMA wants the TPM
> > boot measurement log, which the TPM driver can only get through
> > ACPI. If the platform does not have a TPM, then IMA does not 
> > need ACPI.
> 
> I'm afraid I'm not seeing the connection.  Where does IMA gets the boot
> measurement log?  I see that the TPM exports that log in securityfs as 2
> files (ascii and binary) in tpm_bios.c but I don't see how IMA ever
> makes use of that log either internally to the kernel or through the
> securityfs files.
> 
sorry - bad explanation. IMA reads PCR 0-7, and combines them into
a single "boot_aggregate" as the first entry in the IMA list. For full
attestation, a user level program needs access to both IMA's
boot aggregate, and to the detailed TPM event log upon which
the aggregate is based. So IMA does not itself access the logs,
but the boot aggregate is less useful without them.

As a separate issue, IMA requires the TPM driver to be compiled in
(not loaded as a module) so it is available at IMA initialization, and
the driver apparently requires ACPI in this case. I believe Rajiv
will comment more on this.

dave

> If I'm missing it, and IMA is getting and making use of the bios boot
> log I think we need to instead make the TPM code send a reasonable
> failure code without ACPI and IMA should be changed to handle it.  I
> really don't like the obscure ACPI requirement.

> -Eric



  reply	other threads:[~2009-10-27 20:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-26 13:26 [PATCH] tpm add default function definitions Mimi Zohar
2009-10-26 13:26 ` [PATCH] ima: remove ACPI dependency Mimi Zohar
2009-10-27 13:58   ` Eric Paris
2009-10-27 15:59     ` David Safford
2009-10-27 16:36       ` Eric Paris
2009-10-27 20:42         ` David Safford [this message]
2009-10-27 20:56           ` Eric Paris
2009-10-28 18:51             ` Rajiv Andrade
2009-10-26 14:06 ` [PATCH] tpm add default function definitions Rajiv Andrade
2009-10-27 14:08   ` Eric Paris
  -- strict thread matches above, loose matches on Subject: below --
2010-05-04 22:16 [PATCH] ima: remove ACPI dependency Mimi Zohar
2010-05-05  0:01 ` James Morris
2010-05-14 14:39 ` Mimi Zohar
2010-05-16 23:23   ` James Morris
2009-10-20 20:12 Mimi Zohar
2009-10-25 18:17 ` Jean-Christophe Dubois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256676127.3028.86.camel@localhost.localdomain \
    --to=safford@watson.ibm.com \
    --cc=eparis@parisplace.org \
    --cc=eparis@redhat.com \
    --cc=jcd@tribudubois.net \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=srajiv@linux.vnet.ibm.com \
    --cc=stable@kernel.org \
    --cc=zohar@linux.vnet.ibm.com \
    --cc=zohar@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox