public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@hp.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 4/5] intel-iommu: Reinstate RMRRs if a device is removed from passthrough domain
Date: Wed, 28 Oct 2009 10:06:55 -0600	[thread overview]
Message-ID: <1256746015.5937.128.camel@bling> (raw)
In-Reply-To: <1256740619.9814.141.camel@macbook.infradead.org>

On Wed, 2009-10-28 at 14:36 +0000, David Woodhouse wrote:
> On Tue, 2009-10-27 at 09:50 -0600, Alex Williamson wrote:
> > 
> > Yes, good point.  I'm not seeing any convenient ways to setup a new
> > domain for a device while it's still a member of the si_domain.  It
> > looks like I'd need to extract parts of the get_valid_domain_for_dev()
> > path and ignore any bits about using the already existing domain.
> 
> That seems like a sane plan. That code wants cleaning up anyway, and
> factoring out the 'make new domain' part of get_valid_domain_for_dev()
> should be simple enough.

Ok, I'll work on something along those lines.  FWIW, even though I sent
these as a series, each one stands on it's own.  While I think
reinstating RMRRs is the right thing to do, I don't know of any devices
that break with the current model (the device I know of with the
interesting RMRR usage shouldn't be demoted from the si_domain).  So
please consider pushing patches 2, 3 & 5 upstream (particularly 2).
Thanks,

Alex


  reply	other threads:[~2009-10-28 16:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-26 23:24 [PATCH 0/5] intel-iommu fixes Alex Williamson
2009-10-26 23:24 ` [PATCH 1/5] dma: create dma_generic_alloc/free_coherent() Alex Williamson
2009-10-27  0:57   ` Paul Mundt
2009-10-27  2:26     ` Alex Williamson
2009-10-27  1:47   ` FUJITA Tomonori
2009-10-26 23:25 ` [PATCH 2/5] intel-iommu: Use dma_generic_alloc_coherent() for passthrough mappings Alex Williamson
2009-10-27  3:24   ` [PATCH v2 2/5] intel-iommu: Obey coherent_dma_mask for alloc_coherent on passthrough Alex Williamson
2009-10-26 23:25 ` [PATCH 3/5] intel-iommu: Use max_pfn to determine whether a device can passthrough Alex Williamson
2009-10-26 23:25 ` [PATCH 4/5] intel-iommu: Reinstate RMRRs if a device is removed from passthrough domain Alex Williamson
2009-10-27  8:15   ` David Woodhouse
2009-10-27 15:50     ` Alex Williamson
2009-10-28 14:36       ` David Woodhouse
2009-10-28 16:06         ` Alex Williamson [this message]
2009-10-28 20:35           ` Alex Williamson
2009-10-26 23:25 ` [PATCH 5/5] intel-iommu: Quiet unnecessary output Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256746015.5937.128.camel@bling \
    --to=alex.williamson@hp.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox