From: Mike Galbraith <efault@gmx.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Eric Paris <eparis@redhat.com>,
linux-kernel@vger.kernel.org, hpa@zytor.com,
a.p.zijlstra@chello.nl, tglx@linutronix.de
Subject: Re: [patch] Re: [regression bisect -next] BUG: using smp_processor_id() in preemptible [00000000] code: rmmod
Date: Mon, 02 Nov 2009 21:15:13 +0100 [thread overview]
Message-ID: <1257192913.6688.2.camel@marge.simson.net> (raw)
In-Reply-To: <20091102200133.GB4682@elte.hu>
On Mon, 2009-11-02 at 21:01 +0100, Ingo Molnar wrote:
> * Mike Galbraith <efault@gmx.de> wrote:
>
> > On Mon, 2009-11-02 at 19:28 +0100, Ingo Molnar wrote:
> > > FYI, non-SMP builds broke:
> > >
> > > kernel/built-in.o: In function `kthread_bind':
> > > (.text+0x1d328): undefined reference to `sched_kthread_bind'
> > > make: *** [.tmp_vmlinux1] Error 1
> >
> > Oops. Outside the SMP block might work a little better.
> >
> > sched: Move the body of kthread_bind() to sched.c.
>
> Check the -tip commit notification, i did a somewhat cleaner approach by
> moving all of kthread_bind() into sched.c. No need to keep that small
> wrapper in kthread.c.
Thanks, and sorry for the fumble.
-Mike
next prev parent reply other threads:[~2009-11-02 20:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 2:42 [regression bisect -next] BUG: using smp_processor_id() in preemptible [00000000] code: rmmod Eric Paris
2009-10-29 8:39 ` [patch] " Mike Galbraith
2009-10-29 9:14 ` Ingo Molnar
2009-10-29 9:19 ` Mike Galbraith
2009-10-29 10:48 ` Mike Galbraith
2009-10-29 12:41 ` Eric Paris
2009-11-02 18:28 ` Ingo Molnar
2009-11-02 19:40 ` Mike Galbraith
2009-11-02 20:01 ` Ingo Molnar
2009-11-02 20:15 ` Mike Galbraith [this message]
2009-11-05 10:42 ` There is something with scheduler (was Re: [patch] Re: [regression bisect -next] BUG: using smp_processor_id() in preemptible [00000000] code: rmmod) Lai Jiangshan
2009-11-05 14:13 ` Mike Galbraith
2009-11-05 14:30 ` Mike Galbraith
2009-11-05 23:10 ` [patch] " Mike Galbraith
2009-11-06 2:31 ` Lai Jiangshan
2009-11-06 4:27 ` Mike Galbraith
2009-11-06 5:11 ` Mike Galbraith
2009-11-06 4:46 ` Mike Galbraith
2009-11-02 18:55 ` [tip:sched/urgent] sched: Fix kthread_bind() by moving the body of kthread_bind() to sched.c tip-bot for Mike Galbraith
2009-11-03 7:04 ` tip-bot for Mike Galbraith
2009-11-26 17:09 ` [regression bisect -next] BUG: using smp_processor_id() in preemptible [00000000] code: rmmod Leyendecker, Robert
2009-11-26 17:22 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257192913.6688.2.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=a.p.zijlstra@chello.nl \
--cc=eparis@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox