From: Marcel Holtmann <marcel@holtmann.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
David Miller <davem@davemloft.net>,
johannes@sipsolutions.net, linville@tuxdriver.com,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: Please consider reverting 7d930bc33653d5592dc386a76a38f39c2e962344
Date: Wed, 04 Nov 2009 01:08:05 +0900 [thread overview]
Message-ID: <1257264485.3420.87.camel@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.01.0911030738260.31845@localhost.localdomain>
Hi Linus,
> > no questions that it needs fixed, I agree with you. However just blindly
> > reverting something, because it fixes it for one or two people, might
> > have side effects that causes more problems than the revert would
> > actually fix.
>
> Stop whining. Really.
>
> Everybody understands that it should be fixed. That's not the question.
>
> But it should be fixed _quickly_. In this case, I have a bisection report
> FROM TWO DAYS AGO. And I'm still kicking myself for not just reverting
> that piece-of-shit commit then, because I spent the time to look at the
> oops and the commit, and could tell that it was crap.
>
> Instead, I _did_ wait for the subsystem maintainer to get around to it. As
> a result of waiting, I've now wasted time for a lot of other people.
I do have a patch in my inbox from Johannes from 4 days ago that fixes
this issue.
http://marc.info/?l=linux-wireless&m=125697124819563&w=2
So what is the take away from this now? Do you wanna have Johannes step
over John and Dave and send such a patch directly to you?
Regards
Marcel
next prev parent reply other threads:[~2009-11-03 16:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 5:31 Please consider reverting 7d930bc33653d5592dc386a76a38f39c2e962344 Dmitry Torokhov
2009-11-03 6:49 ` David Miller
2009-11-03 6:52 ` Dmitry Torokhov
2009-11-03 7:16 ` Marcel Holtmann
2009-11-03 7:44 ` Johannes Berg
2009-11-03 8:22 ` Dmitry Torokhov
2009-11-03 8:31 ` Johannes Berg
2009-11-03 8:47 ` Dmitry Torokhov
2009-11-03 8:57 ` Johannes Berg
2009-11-03 15:29 ` Marcel Holtmann
2009-11-03 15:38 ` Linus Torvalds
2009-11-05 19:19 ` Pavel Machek
2009-11-03 15:31 ` Linus Torvalds
2009-11-04 6:34 ` Andrew Morton
2009-11-04 8:41 ` David Miller
2009-11-04 15:23 ` Andrew Morton
2009-11-04 16:32 ` David Miller
2009-11-03 15:26 ` Linus Torvalds
2009-11-03 15:36 ` Marcel Holtmann
2009-11-03 15:43 ` Linus Torvalds
2009-11-03 16:07 ` Linus Torvalds
2009-11-03 16:08 ` Marcel Holtmann [this message]
2009-11-03 16:23 ` Linus Torvalds
2009-11-03 16:37 ` Linus Torvalds
2009-11-03 16:44 ` Marcel Holtmann
2009-11-03 16:59 ` Linus Torvalds
2009-11-03 16:29 ` Ingo Molnar
2009-11-03 16:49 ` Marcel Holtmann
2009-11-03 17:04 ` Ingo Molnar
2009-11-03 17:24 ` Luis R. Rodriguez
2009-11-03 17:37 ` Linus Torvalds
2009-11-03 17:49 ` Dmitry Torokhov
2009-11-03 17:55 ` Luis R. Rodriguez
2009-11-03 15:54 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257264485.3420.87.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox