Re: [PATCH 3/3] sched: Disable affine wakeups by default

Arjan van de Ven
2009-10-26T04:51:21Z

On Mon, 26 Oct 2009 05:38:27 +0100
Mike Galbraith <efault@gmx.de> wrote:

> On Mon, 2009-10-26 at 02:53 +0100, Peter Zijlstra wrote:
> > On Sun, 2009-10-25 at 23:04 +0100, Mike Galbraith wrote:
> > > if (want_affine && (tmp->flags & SD_WAKE_AFFINE)
> > > &&
> > > - cpumask_test_cpu(prev_cpu,
> > > sched_domain_span(tmp))) {
> > > + (level == SD_LV_SIBLING || level
> > > == SD_LV_MC)) {
> >
> > quick comment without actually having looked at the patch, we should
> > really get rid of sd->level and encode properties of the sched
> > domains in sd->flags.
>
> Yeah, sounds right, while writing that, it looked kinda ugly. I
> suppose arch land needs to encode cache property somehow if I really
> want to be able to target cache on multicore. Booting becomes..
> exciting when I tinker down there.

or we just use SD_WAKE_AFFINE / SD_BALANCE_WAKE for this...

--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org