Re: [PATCH 3/3] sched: Disable affine wakeups by default

Mike Galbraith
2009-10-28T07:25:45Z

On Tue, 2009-10-27 at 15:35 +0100, Mike Galbraith wrote:
> On Mon, 2009-10-26 at 02:53 +0100, Peter Zijlstra wrote:
> > On Sun, 2009-10-25 at 23:04 +0100, Mike Galbraith wrote:
> > > if (want_affine && (tmp->flags & SD_WAKE_AFFINE) &&
> > > - cpumask_test_cpu(prev_cpu, sched_domain_span(tmp))) {
> > > + (level == SD_LV_SIBLING || level == SD_LV_MC)) {
> >
> > quick comment without actually having looked at the patch, we should
> > really get rid of sd->level and encode properties of the sched domains
> > in sd->flags.
>
> I used SD_PREFER_SIBLING in the below. Did I break anything?

Um, other than taskset.

> + if (candidate == -1 || candidate == cpu) {
> + for_each_cpu(i, sched_domain_span(tmp)) {

if (!cpumask_test_cpu(i, &p->cpus_allowed))
continue;

(i think i'm going to need that domain flag in a few minutes anyway)

-Mike