public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Darren Hart <dvhltc@us.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arjan van de Ven <arjan@infradead.org>,
	Andi Kleen <andi@firstfloor.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Mike Fulton <fultonm@ca.ibm.com>,
	Sean Foley <Sean_Foley@ca.ibm.com>
Subject: Re: [RFC][PATCH] Add prctl to set sibling thread names
Date: Thu, 05 Nov 2009 11:11:15 -0800	[thread overview]
Message-ID: <1257448275.3923.1.camel@localhost.localdomain> (raw)
In-Reply-To: <20091105143959.2093.A69D9226@jp.fujitsu.com>

On Thu, 2009-11-05 at 14:42 +0900, KOSAKI Motohiro wrote:
> > KOSAKI Motohiro wrote:
> > >> KOSAKI Motohiro wrote:
> > >>
> > >>> John, I'd prefer to suggested another design.
> > >>> How about this?
> > >>>
> > >>> 1. remove pid argument from prctl
> > >>> 2. cancel pthread_setname_np()
> > >>> 3. instead, create pthread_attr_setname_np()
> > >>> 4. pthread_create() change own thread name by pthread_attr.
> > >>>
> > >>> It avoid many racy problem automatically.
> > >> Perhaps, but it also greatly reduces the flexibility of the 
> > >> implementation by restricting name changes to create time.
> > > 
> > > Hm.
> > > if your program really need to change another thread name, can you please tell us
> > > why it is necessary and when it is used?
> > 
> > I think John's previous mails covered that pretty well. As for doing the 
> > name change at create time, or sometime later, it just seems to me that 
> > the flexibility of doing so later is worth having. While I know we don't 
> > have to follow other systems implementations, in this case 
> > pthread_setname_np() seems a reasonable model to follow to me.
> 
> You only said your mode is more flexible. but I want to know _why_ this flexibiliby is
> necessay. please tell us concrete use-case.

You can read Sean's example from this thread here:
	http://lkml.org/lkml/2009/10/27/259

thanks
-john



  reply	other threads:[~2009-11-05 19:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-21 23:21 [RFC][PATCH] Add prctl to set sibling thread names john stultz
2009-10-22  0:28 ` Andi Kleen
2009-10-22  0:42   ` john stultz
2009-10-22  0:44     ` Andi Kleen
2009-10-22  0:48 ` Arjan van de Ven
2009-10-22  0:49   ` Andi Kleen
2009-10-22  2:48     ` Arjan van de Ven
2009-10-24  3:54       ` Andi Kleen
2009-10-26 23:56         ` john stultz
2009-10-22  0:52   ` john stultz
2009-10-22  2:00     ` Andrew Morton
2009-11-05  2:26       ` KOSAKI Motohiro
2009-11-05  5:17         ` Darren Hart
2009-11-05  5:22           ` KOSAKI Motohiro
2009-11-05  5:36             ` Darren Hart
2009-11-05  5:42               ` KOSAKI Motohiro
2009-11-05 19:11                 ` john stultz [this message]
     [not found]                 ` <OF5EE04242.D2B67AF2-ON85257665.0064683D-85257665.0068209E@ca.ibm.com>
2009-11-10  5:27                   ` KOSAKI Motohiro
2009-11-10 20:16                     ` john stultz
2009-11-11  0:04                       ` KOSAKI Motohiro
  -- strict thread matches above, loose matches on Subject: below --
2009-11-05 19:03 Sean Foley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1257448275.3923.1.camel@localhost.localdomain \
    --to=johnstul@us.ibm.com \
    --cc=Sean_Foley@ca.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=arjan@infradead.org \
    --cc=dvhltc@us.ibm.com \
    --cc=fultonm@ca.ibm.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox