From: Peter Zijlstra <peterz@infradead.org>
To: Mike Galbraith <efault@gmx.de>
Cc: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Gautham R Shenoy <ego@in.ibm.com>
Subject: Re: specjbb2005 and aim7 regression with 2.6.32-rc kernels
Date: Mon, 09 Nov 2009 10:15:04 +0100 [thread overview]
Message-ID: <1257758104.4108.152.camel@laptop> (raw)
In-Reply-To: <1257750573.6414.29.camel@marge.simson.net>
On Mon, 2009-11-09 at 08:09 +0100, Mike Galbraith wrote:
> + smp_read_barrier_depends();
> cpumask_setall(cpus);
> + cpumask_and(cpus, cpus, cpu_online_mask);
how about: cpumask_copy(cpus, cpu_online_mask); ?
Also, iirc cpu_online_mask is guaranteed stable when preemption is
disabled, otherwise you need to use get/put_online_cpus(), an
rmb_depends() won't do.
next prev parent reply other threads:[~2009-11-09 9:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 7:38 specjbb2005 and aim7 regression with 2.6.32-rc kernels Zhang, Yanmin
2009-11-06 8:02 ` Mike Galbraith
2009-11-06 8:04 ` Ingo Molnar
2009-11-09 6:19 ` Zhang, Yanmin
2009-11-09 7:09 ` Mike Galbraith
2009-11-09 9:15 ` Peter Zijlstra [this message]
2009-11-09 9:44 ` Gautham R Shenoy
2009-11-09 9:57 ` Mike Galbraith
2009-11-09 9:55 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257758104.4108.152.camel@laptop \
--to=peterz@infradead.org \
--cc=efault@gmx.de \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox