From: Peter Zijlstra <peterz@infradead.org>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: mingo@redhat.com, hpa@zytor.com, paulus@samba.org,
linux-kernel@vger.kernel.org, ink@jurassic.park.msu.ru,
tglx@linutronix.de, rth@twiddle.net, mingo@elte.hu,
mcree@orcon.net.nz, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] perf tools, Alpha: Add Alpha support to perf.h
Date: Tue, 10 Nov 2009 22:21:36 +0100 [thread overview]
Message-ID: <1257888096.4108.482.camel@laptop> (raw)
In-Reply-To: <84144f020910260508n47ef067ci4adfd02cd3f87edd@mail.gmail.com>
On Mon, 2009-10-26 at 14:08 +0200, Pekka Enberg wrote:
> > +#ifdef __alpha__
> > +#include "../../arch/alpha/include/asm/unistd.h"
> > +#define rmb() asm volatile("mb" ::: "memory")
> > +#define cpu_relax() asm volatile("" ::: "memory")
> > +#endif
>
> OK, I'll bite. We tell userspace developers not to include kernel
> headers. Why is it okay for perf to do it (especially for something
> that's in asm)?
The reason we take the explicit arch header is because we need the perf
syscall thingy, which isn't yet in the installed system unistd.h because
that's probably some ancient version.
Once distro's have had perf enabled kernels for long enough that all of
userspace has the syscall bits we can remove it.
next prev parent reply other threads:[~2009-11-10 21:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 8:32 [PATCH] [alpha] Add minimal support for software performance events Michael Cree
2009-10-26 8:48 ` Ingo Molnar
2009-10-27 8:09 ` Michael Cree
2009-11-08 12:22 ` Ingo Molnar
2009-11-08 12:27 ` Ingo Molnar
2009-11-11 7:43 ` Michael Cree
2009-11-11 7:48 ` [tip:perf/core] perf tools: Test -fstack-protector-all compiler option for inclusion in CFLAGS tip-bot for Michael Cree
2009-10-27 18:29 ` [PATCH] [alpha] Add minimal support for software performance events Matt Turner
2009-10-28 20:56 ` Sam Ravnborg
2009-10-26 11:38 ` [tip:perf/core] perf tools, Alpha: Add Alpha support to perf.h tip-bot for Michael Cree
2009-10-26 12:08 ` Pekka Enberg
2009-10-26 12:22 ` Ingo Molnar
2009-10-28 20:58 ` Sam Ravnborg
2009-11-10 21:21 ` Peter Zijlstra [this message]
2009-12-01 4:30 ` [PATCH] [alpha] Add minimal support for software performance events Matt Turner
2009-12-01 9:31 ` Michael Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257888096.4108.482.camel@laptop \
--to=peterz@infradead.org \
--cc=hpa@zytor.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mcree@orcon.net.nz \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=penberg@cs.helsinki.fi \
--cc=rth@twiddle.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox