Re: [PATCH 2/2] regulator/mc13783: various cleanups

[Liam Girdwood <lrg@slimlogic.co.uk>]

On Tue, 2009-11-10 at 09:18 +0100, Uwe Kleine-König wrote:
> - define needed registers and bits in the driver
> - properly namespace functions and structs
> - fix locking as required by patch
>   "mfd/mc13783: near complete rewrite"
> - use platform_data as provided by "mfd/mc13783: near complete rewrite"
>   instead of accessing struct mc13783
> - struct mc13783_regulator_priv.desc is (and was) unused and so can go
>   away
> - use cpp magic to initialize mc13783_regulators
> - bring MODULE_LICENSE in sync with actual copyright
> - minor style fixes
> 
> This allows not including mc13783-private.h which I intend to remove
> soon.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Liam Girdwood <lrg@slimlogic.co.uk>
> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> ---

I assume the new mc13783 function and type definitions are in mfd-next ?

  CC [M]  drivers/regulator/mc13783-regulator.o
drivers/regulator/mc13783-regulator.c: In function ‘mc13783_regulator_enable’:
drivers/regulator/mc13783-regulator.c:116: error: implicit declaration of function ‘mc13783_lock’
drivers/regulator/mc13783-regulator.c:117: error: implicit declaration of function ‘mc13783_reg_rmw’
drivers/regulator/mc13783-regulator.c:120: error: implicit declaration of function ‘mc13783_unlock’
drivers/regulator/mc13783-regulator.c: In function ‘mc13783_regulator_is_enabled’:
drivers/regulator/mc13783-regulator.c:148: error: implicit declaration of function ‘mc13783_reg_read’
drivers/regulator/mc13783-regulator.c: In function ‘mc13783_regulator_probe’:
drivers/regulator/mc13783-regulator.c:175: error: dereferencing pointer to incomplete type
drivers/regulator/mc13783-regulator.c:182: error: dereferencing pointer to incomplete type
drivers/regulator/mc13783-regulator.c:183: error: dereferencing pointer to incomplete type
drivers/regulator/mc13783-regulator.c: In function ‘mc13783_regulator_remove’:
drivers/regulator/mc13783-regulator.c:215: error: dereferencing pointer to incomplete type
make[1]: *** [drivers/regulator/mc13783-regulator.o] Error 1
make: *** [drivers/regulator/mc13783-regulator.o] Error 2


Liam