From: Jerome Glisse <jglisse@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: airlied@gmail.com, dri-devel@lists.sf.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/radeon/kms: Fix oops when set_base is call with no FB
Date: Thu, 12 Nov 2009 12:02:58 +0100 [thread overview]
Message-ID: <1258023778.2473.2.camel@localhost> (raw)
In-Reply-To: <20091110143056.defb1a82.akpm@linux-foundation.org>
On Tue, 2009-11-10 at 14:30 -0800, Andrew Morton wrote:
> On Wed, 4 Nov 2009 20:03:19 +0100
> Jerome Glisse <jglisse@redhat.com> wrote:
>
> > Just do nothings crct_set_base i call with no FB.
> >
>
> hmpf. It's obvious that you spent hours carefully describing this
> patch for us.
>
Sorry, truth is i don't understand why crtc set_base call back
can be call with a null fb, i did just replicate what intel kms
and other part of radeon kms was doing in front of such situation.
It should go down to 2.6.31, useless before as there is no KMS
for radeon in earlier version. The oops will happen when user
switch btw X & vt or in some case when changing mode.
Will clearly state my ignorance in future patch.
Cheers,
Jerome
next prev parent reply other threads:[~2009-11-12 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 19:03 [PATCH] drm/radeon/kms: Fix oops when set_base is call with no FB Jerome Glisse
2009-11-10 22:30 ` Andrew Morton
2009-11-12 11:02 ` Jerome Glisse [this message]
2009-11-13 22:50 ` Andrew Morton
2009-11-19 20:48 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258023778.2473.2.camel@localhost \
--to=jglisse@redhat.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.sf.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox