public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Gerst <brgerst@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] x86, 32-bit: Don't push args on stack in kernel_thread_helper
Date: Fri, 13 Nov 2009 14:54:57 -0500	[thread overview]
Message-ID: <1258142098-3832-4-git-send-email-brgerst@gmail.com> (raw)
In-Reply-To: <1258142098-3832-1-git-send-email-brgerst@gmail.com>

regparm(3) is the normal calling convention now.

Signed-off-by: Brian Gerst <brgerst@gmail.com>
---
 arch/x86/kernel/entry_32.S |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
index 2778ae3..96e9c32 100644
--- a/arch/x86/kernel/entry_32.S
+++ b/arch/x86/kernel/entry_32.S
@@ -985,11 +985,7 @@ ENTRY(kernel_thread_helper)
 	pushl $0		# fake return address for unwinder
 	CFI_STARTPROC
 	movl %edi,%eax
-	push %edi
-	CFI_ADJUST_CFA_OFFSET 4
 	call *%esi
-	push %eax
-	CFI_ADJUST_CFA_OFFSET 4
 	call do_exit
 	ud2			# padding for call trace
 	CFI_ENDPROC
-- 
1.6.2.5


  parent reply	other threads:[~2009-11-13 19:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13 19:54 [PATCH 0/4] x86: Merge kernel_thread() Brian Gerst
2009-11-13 19:54 ` [PATCH 1/4] x86, 64-bit: Move kernel_thread to C Brian Gerst
2009-11-13 19:54 ` [PATCH 2/4] x86: Merge 32/64-bit kernel_thread Brian Gerst
2009-11-13 19:54 ` Brian Gerst [this message]
2009-11-13 19:54 ` [PATCH 4/4] x86, 64-bit: Use user_mode() to determine new stack pointer in copy_thread() Brian Gerst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258142098-3832-4-git-send-email-brgerst@gmail.com \
    --to=brgerst@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox