From: Daniel Walker <dwalker@fifo99.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
Len Brown <len.brown@intel.com>, Lin Ming <ming.m.lin@intel.com>,
Bob Moore <robert.moore@intel.com>,
Andi Kleen <ak@linux.intel.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 4/5] acpi: fix trivial warning
Date: Sun, 15 Nov 2009 09:32:32 -0800 [thread overview]
Message-ID: <1258306352.6428.10.camel@desktop> (raw)
In-Reply-To: <94a0d4530911150927l3224e815ha6ff17aab6f19251@mail.gmail.com>
On Sun, 2009-11-15 at 19:27 +0200, Felipe Contreras wrote:
> On Sun, Nov 15, 2009 at 7:15 PM, Daniel Walker <dwalker@fifo99.com> wrote:
> > On Fri, 2009-11-13 at 22:28 +0200, Felipe Contreras wrote:
> >> That doesn't seem too positive. Or at least there's no indication that
> >> somebody will pick it up.
> >
> > I'd re-submit with a better description of the patch. You should always
> > try to describe what your doing as accurately as possible so the
> > maintainer doesn't have to work very hard to know what your doing.
>
> There's nothing to add. It's a patch to cleanup the coding style, that's it.
How do you know the coding style isn't correct? Did you just visually
inspect it?
> > That
> > particular patch just has a one liner description that wasn't very
> > informative .. Either that or re-submit your series without that patch
> > if you don't have confidence in it.
>
> All of my patches have been picked up, except the ones for ACPI. I
> haven't received a single comment from them, which would explain the
> current state of the code.
>
> If somebody raised the hand and said; I'll merge this, please resend,
> I'd do that, otherwise I think it's a waste of time.
Patches often times aren't accepted in the first submission, could be
for lots of reasons. It's your series tho ..
Daniel
next prev parent reply other threads:[~2009-11-15 17:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 19:38 [PATCH 0/5] Trivial warning cleanups Felipe Contreras
2009-09-13 19:38 ` [PATCH 1/5] Trivial whitespace cleanups Felipe Contreras
2009-09-13 19:38 ` [PATCH 2/5] kbuild: fix warning when domainname is not available Felipe Contreras
2009-09-13 19:38 ` [PATCH 3/5] kbuild: mkcompile_h: trivial cleanups Felipe Contreras
2009-09-13 19:38 ` [PATCH 4/5] acpi: fix trivial warning Felipe Contreras
2009-09-13 19:38 ` [PATCH 5/5] acpi: fix trivial warnings caused by previous commmit Felipe Contreras
2009-09-14 13:55 ` [PATCH 4/5] acpi: fix trivial warning Daniel Walker
2009-09-14 14:34 ` Felipe Contreras
2009-09-14 15:02 ` Daniel Walker
2009-11-12 0:23 ` Felipe Contreras
2009-11-13 17:43 ` Daniel Walker
2009-11-13 20:28 ` Felipe Contreras
2009-11-13 20:37 ` Thiago Farina
2009-11-15 17:15 ` Daniel Walker
2009-11-15 17:27 ` Felipe Contreras
2009-11-15 17:32 ` Daniel Walker [this message]
2009-11-15 17:54 ` Alexey Starikovskiy
2009-11-15 17:58 ` Daniel Walker
2009-11-15 18:10 ` Alexey Starikovskiy
2009-11-15 18:09 ` Daniel Walker
2009-11-16 1:27 ` Lin Ming
2009-09-13 21:12 ` [PATCH 2/5] kbuild: fix warning when domainname is not available Mike Frysinger
2009-09-13 21:42 ` Felipe Contreras
2009-09-13 21:58 ` Mike Frysinger
2009-09-13 22:04 ` Felipe Contreras
2009-09-14 4:46 ` Sam Ravnborg
2009-09-14 8:25 ` Felipe Contreras
2009-09-14 13:43 ` Mike Frysinger
2009-09-15 8:38 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258306352.6428.10.camel@desktop \
--to=dwalker@fifo99.com \
--cc=ak@linux.intel.com \
--cc=felipe.contreras@gmail.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox