Re: [PATCH 2/5] kbuild: fix warning when domainname is not available

Mike Frysinger
2009-09-13T21:58:40Z

.
On Sun, Sep 13, 2009 at 17:42, Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> On Mon, Sep 14, 2009 at 12:12 AM, Mike Frysinger <vapier.adi@gmail.com> wrote:
>> On Sun, Sep 13, 2009 at 15:38, Felipe Contreras wrote:
>>> +  if $domain; then
>>
>> is this really correct ?  i think you meant to use:
>> [ -n "$domain" ]
>
> What is the difference?
>
> $domain unset
> test -n "" -> false
> test -> false
>
> $domain is a valid string
> test -n "string" -> true
> test "string" -> true

except that you didnt invoke `test` anywhere. you're executing the
contents of $domain.
-mike