Re: [PATCH 4/5] acpi: fix trivial warning

Alexey Starikovskiy
2009-11-15T17:54:05Z

You've made changes to automatically generated files, so all the style
changes
would be overwritten when next time these files are generated -- all the
files go through
Lindent, and almost all your changes were introduced by it. If you
really want to make
style changes to ACPICA files, try to play with Lindent, so it produce
what you want.
If you have anything beside style patches, please submit them separately

Regards,
Alex.

Daniel Walker wrote:
> On Sun, 2009-11-15 at 19:27 +0200, Felipe Contreras wrote:
>
>> On Sun, Nov 15, 2009 at 7:15 PM, Daniel Walker <dwalker@fifo99.com> wrote:
>>
>>> On Fri, 2009-11-13 at 22:28 +0200, Felipe Contreras wrote:
>>>
>>>> That doesn't seem too positive. Or at least there's no indication that
>>>> somebody will pick it up.
>>>>
>>> I'd re-submit with a better description of the patch. You should always
>>> try to describe what your doing as accurately as possible so the
>>> maintainer doesn't have to work very hard to know what your doing.
>>>
>> There's nothing to add. It's a patch to cleanup the coding style, that's it.
>>
>
> How do you know the coding style isn't correct? Did you just visually
> inspect it?
>
>
>>> That
>>> particular patch just has a one liner description that wasn't very
>>> informative .. Either that or re-submit your series without that patch
>>> if you don't have confidence in it.
>>>
>> All of my patches have been picked up, except the ones for ACPI. I
>> haven't received a single comment from them, which would explain the
>> current state of the code.
>>
>> If somebody raised the hand and said; I'll merge this, please resend,
>> I'd do that, otherwise I think it's a waste of time.
>>
>
> Patches often times aren't accepted in the first submission, could be
> for lots of reasons. It's your series tho ..
>
> Daniel
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>