* [PATCH] leds-gpio: fix possible crash on OF device unbinding
@ 2009-11-15 22:48 Dmitry Eremin-Solenikov
0 siblings, 0 replies; only message in thread
From: Dmitry Eremin-Solenikov @ 2009-11-15 22:48 UTC (permalink / raw)
To: Richard Purdie; +Cc: David Brownell, linux-kernel
If there are leds present in the OF tree, but the GPIOs for (some) of
them are unavailable, led_data doesn't get populated with correct
devices. Then, on device unbinding, one can crash the kernel.
Workaround this by setting led->gpio to invalid value early.
Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
drivers/leds/leds-gpio.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index 7467980..e5225d2 100644
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -78,6 +78,8 @@ static int __devinit create_gpio_led(const struct gpio_led *template,
{
int ret, state;
+ led_dat->gpio = -1;
+
/* skip leds that aren't available */
if (!gpio_is_valid(template->gpio)) {
printk(KERN_INFO "Skipping unavailable LED gpio %d (%s)\n",
--
1.6.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-11-15 22:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-15 22:48 [PATCH] leds-gpio: fix possible crash on OF device unbinding Dmitry Eremin-Solenikov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox