[PATCH 0/2] giantec,gt24c04a eeproms for qnap ts433

[PATCH 0/2] giantec,gt24c04a eeproms for qnap ts433

[Heiko Stuebner]

Add the binding and dt-nodes for the product-data eeproms on the TS433.

Heiko Stuebner (2):
  dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
  arm64: dts: rockchip: add product-data eeproms to QNAP TS433

 .../devicetree/bindings/eeprom/at24.yaml      |  1 +
 .../boot/dts/rockchip/rk3568-qnap-ts433.dts   | 20 +++++++++++++++++++
 2 files changed, 21 insertions(+)

-- 
2.39.2

[PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A

[Heiko Stuebner]

The gt24c04a is just yet another 2404 compatible eeprom, and does not
follow the generic naming matching, so add a separate compatible for it.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 Documentation/devicetree/bindings/eeprom/at24.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
index e396e47b2f13c..b6239ec3512b3 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.yaml
+++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
@@ -116,6 +116,7 @@ properties:
           - const: atmel,24c02
       - items:
           - enum:
+              - giantec,gt24c04a
               - onnn,cat24c04
               - onnn,cat24c05
               - rohm,br24g04
-- 
2.39.2

Re: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A

[Krzysztof Kozlowski]

On 10/08/2024 23:14, Heiko Stuebner wrote:
> The gt24c04a is just yet another 2404 compatible eeprom, and does not
> follow the generic naming matching, so add a separate compatible for it.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  Documentation/devicetree/bindings/eeprom/at24.yaml | 1 +

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Sat, 10 Aug 2024 23:14:37 +0200, Heiko Stuebner wrote:
> The gt24c04a is just yet another 2404 compatible eeprom, and does not
> follow the generic naming matching, so add a separate compatible for it.
> 
> 

Applied, thanks!

[1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
      commit: a825dea2cd27a30e49816f18b7bc16545d5f0f89

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A

[Heiko Stübner]

Hi,

Am Sonntag, 11. August 2024, 21:27:13 CEST schrieb Bartosz Golaszewski:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> 
> On Sat, 10 Aug 2024 23:14:37 +0200, Heiko Stuebner wrote:
> > The gt24c04a is just yet another 2404 compatible eeprom, and does not
> > follow the generic naming matching, so add a separate compatible for it.
> > 
> > 
> 
> Applied, thanks!
> 
> [1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
>       commit: a825dea2cd27a30e49816f18b7bc16545d5f0f89

just for my understanding, where is this commit living now?

Because linux next seems to know it [0], but also says that
"Notice: this object is not reachable from any branch."


Thanks
Heiko

[0] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a825dea2cd27a30e49816f18b7bc16545d5f0f89

Re: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A

[Bartosz Golaszewski]

On Thu, 15 Aug 2024 at 18:48, Heiko Stübner <heiko@sntech.de> wrote:
>
> Hi,
>
> Am Sonntag, 11. August 2024, 21:27:13 CEST schrieb Bartosz Golaszewski:
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> >
> > On Sat, 10 Aug 2024 23:14:37 +0200, Heiko Stuebner wrote:
> > > The gt24c04a is just yet another 2404 compatible eeprom, and does not
> > > follow the generic naming matching, so add a separate compatible for it.
> > >
> > >
> >
> > Applied, thanks!
> >
> > [1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
> >       commit: a825dea2cd27a30e49816f18b7bc16545d5f0f89
>
> just for my understanding, where is this commit living now?
>
> Because linux next seems to know it [0], but also says that
> "Notice: this object is not reachable from any branch."
>
>
> Thanks
> Heiko
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a825dea2cd27a30e49816f18b7bc16545d5f0f89
>
>

It lives in my kernel.org tree[1]. You can get that information from
the MAINTAINERS file.

Bart

[1] https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git/log/?h=at24/for-next

Re: [PATCH 1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A

[Krzysztof Kozlowski]

On 16/08/2024 10:03, Bartosz Golaszewski wrote:
>>>
>>> Applied, thanks!
>>>
>>> [1/2] dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
>>>       commit: a825dea2cd27a30e49816f18b7bc16545d5f0f89
>>
>> just for my understanding, where is this commit living now?
>>
>> Because linux next seems to know it [0], but also says that
>> "Notice: this object is not reachable from any branch."
>>
>>
>> Thanks
>> Heiko
>>
>> [0] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a825dea2cd27a30e49816f18b7bc16545d5f0f89
>>
>>
> 
> It lives in my kernel.org tree[1]. You can get that information from
> the MAINTAINERS file.

Or use simple template - only one entry needed:
b4.thanks-commit-url-mask = https://git.kernel.org/MR_FOO/linux/c/%s

page 44 of PDF:
https://lpc.events/event/17/contributions/1498/#preview:2452

Best regards,
Krzysztof

[PATCH 2/2] arm64: dts: rockchip: add product-data eeproms to QNAP TS433

[Heiko Stuebner]

The device contains two i2c-connected eeproms holding some product-
specific values. One sitting on the mainboard and one on the statically
connected backplane.

While the eeprom chips themself have a size of 512 byte, the eeprom data
only uses 256 byte each, probably to stay compatible with other models.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 .../boot/dts/rockchip/rk3568-qnap-ts433.dts   | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
index 110c323786848..7bd32d230ad2f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
@@ -458,6 +458,26 @@ rtc_rv8263: rtc@51 {
 		reg = <0x51>;
 		wakeup-source;
 	};
+
+	/* eeprom for vital-product-data on the mainboard */
+	eeprom@54 {
+		compatible = "giantec,gt24c04a", "atmel,24c04";
+		reg = <0x54>;
+		label = "VPD_MB";
+		num-addresses = <2>;
+		pagesize = <16>;
+		read-only;
+	};
+
+	/* eeprom for vital-product-data on the backplane */
+	eeprom@56 {
+		compatible = "giantec,gt24c04a", "atmel,24c04";
+		reg = <0x56>;
+		label = "VPD_BP";
+		num-addresses = <2>;
+		pagesize = <16>;
+		read-only;
+	};
 };
 
 &mdio0 {
-- 
2.39.2

Re: (subset) [PATCH 0/2] giantec,gt24c04a eeproms for qnap ts433

[Heiko Stuebner]

On Sat, 10 Aug 2024 23:14:36 +0200, Heiko Stuebner wrote:
> Add the binding and dt-nodes for the product-data eeproms on the TS433.
> 
> Heiko Stuebner (2):
>   dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A
>   arm64: dts: rockchip: add product-data eeproms to QNAP TS433
> 
> .../devicetree/bindings/eeprom/at24.yaml      |  1 +
>  .../boot/dts/rockchip/rk3568-qnap-ts433.dts   | 20 +++++++++++++++++++
>  2 files changed, 21 insertions(+)
> 
> [...]

Applied, thanks!

[2/2] arm64: dts: rockchip: add product-data eeproms to QNAP TS433
      commit: da6f4130234448122fe3e66c8116f7d9eea8a5c7

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>