public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
	linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 1/2] perf top: Introduce --hide_{user,kernel}_symbols
Date: Tue, 17 Nov 2009 07:44:55 +0100	[thread overview]
Message-ID: <1258440295.15006.26.camel@marge.simson.net> (raw)
In-Reply-To: <20091117063332.GA8614@elte.hu>

On Tue, 2009-11-17 at 07:33 +0100, Ingo Molnar wrote:
> btw., the user symbol printouts of perf top cause some display problems 
> - such as below. The DSO printout is way too long to fit into 92 cols, 
> wrapping around in my terminal and making much of the output unreadable.
> 
> Could we cut it by default please?

An option to turn off userland would be nice too.  If you're interested
in the kernel, a display like below is.. suboptimal. (--dso?)

> Also, it would be nice to only print the basename() portion of the DSO. 
> Both the /lib64 and the /opt/crossgcc/cross/libexec/ portion is 
> repetitive and not really important in understanding perf top output. 
> There should perhaps be a 'dso-abs' symbol column that prints out the 
> full pathname?
> 
> 	Ingo
> 
> ------------->
> 
> $ echo $COLUMNS $LINES
> 92 28
> 
> $ perf top
> 
> ------------------------------------------------------------------------------
>    PerfTop:   13676 irqs/sec  kernel:14.3% [1000Hz cycles],  (all, 16 CPUs)
> ------------------------------------------------------------------------------
> 
>              samples  pcnt function                                 DSO
>              _______ _____ ________________________________ ________________
> 
>              2315.00  4.6% ht_lookup_with_hash              /opt/crossgcc/cross/libexec/gcc/x86_64-linux/4.4.2/cc1
>              2202.00  4.4% _cpp_lex_direct                  /opt/crossgcc/cross/libexec/gcc/x86_64-linux/4.4.2/cc1
>              1490.00  3.0% _int_malloc                      /lib64/libc-2.10.90.so
>              1172.00  2.3% _cpp_clean_line                  /opt/crossgcc/cross/libexec/gcc/x86_64-linux/4.4.2/cc1
>               887.00  1.8% lex_identifier                   /opt/crossgcc/cross/libexec/gcc/x86_64-linux/4.4.2/cc1
>               845.00  1.7% clear_page_c                     [kernel]
>               836.00  1.7% cpp_get_token                    /opt/crossgcc/cross/libexec/gcc/x86_64-linux/4.4.2/cc1
>               795.00  1.6% ggc_alloc_stat                   /opt/crossgcc/cross/libexec/gcc/x86_64-linux/4.4.2/cc1
>               675.00  1.3% cpp_output_token                 /opt/crossgcc/cross/libexec/gcc/x86_64-linux/4.4.2/cc1
>               675.00  1.3% __GI_memset                      /lib64/libc-2.10.90.so
>               622.00  1.2% _int_free                        /lib64/libc-2.10.90.so
>               609.00  1.2% page_fault                       [kernel]
>               568.00  1.1% gimplify_expr                    /opt/crossgcc/cross/libexec/gcc/x86_64-linux/4.4.2/cc1
>               567.00  1.1% _cpp_lex_token                   /opt/crossgcc/cross/libexec/gcc/x86_64-linux/4.4.2/cc1
>               440.00  0.9% yylex                            /home/mingo/tip/scripts/genksyms/genksyms
>               423.00  0.8% __GI___libc_malloc               /lib64/libc-2.10.90.so
>               417.00  0.8% walk_tree_1                      /opt/crossgcc/cross/libexec/gcc/x86_64-linux/4.4.2/cc1
>               416.00  0.8% __GI_memcpy                      /lib64/libc-2.10.90.so
>               377.00  0.7% enter_macro_context              /opt/crossgcc/cross/libexec/gcc/x86_64-linux/4.4.2/cc1
> 


  reply	other threads:[~2009-11-17  6:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-16 23:45 [PATCH 1/2] perf top: Introduce --hide_{user,kernel}_symbols Arnaldo Carvalho de Melo
2009-11-16 23:45 ` [PATCH 2/2] perf buildid-list: Always show the DSO name Arnaldo Carvalho de Melo
2009-11-17  6:32   ` [tip:perf/core] " tip-bot for Arnaldo Carvalho de Melo
2009-11-17  6:32 ` [tip:perf/core] perf top: Introduce --hide_{user,kernel}_symbols tip-bot for Arnaldo Carvalho de Melo
2009-11-17  6:33 ` [PATCH 1/2] " Ingo Molnar
2009-11-17  6:44   ` Mike Galbraith [this message]
2009-11-17  6:56     ` Ingo Molnar
2009-11-17  7:26       ` Mike Galbraith
2009-11-17 12:57   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258440295.15006.26.camel@marge.simson.net \
    --to=efault@gmx.de \
    --cc=acme@infradead.org \
    --cc=acme@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox