public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Eduardo Valentin <eduardo.valentin@nokia.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	David Brownell <dbrownell@users.sourceforge.net>,
	Samuel Ortiz <sameo@linux.intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"\\\"De-Schrijver Peter (Nokia-D/Helsinki)\\\"" 
	<Peter.De-Schrijver@nokia.com>
Subject: Re: [PATCH 1/1] twl4030-regulator: Remove regulator from all groups when disabling
Date: Fri, 20 Nov 2009 19:07:59 +0000	[thread overview]
Message-ID: <1258744079.3640.435.camel@odin> (raw)
In-Reply-To: <1258734559-15594-1-git-send-email-eduardo.valentin@nokia.com>

On Fri, 2009-11-20 at 18:29 +0200, Eduardo Valentin wrote:
> Just remove regulator from all groups when disabling. This way we
> avoid problems if boot loader touches twl4030 registers.
> 
> Signed-off-by: Eduardo Valentin <eduardo.valentin@nokia.com>
> ---
>  drivers/regulator/twl4030-regulator.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/regulator/twl4030-regulator.c b/drivers/regulator/twl4030-regulator.c
> index e2032fb..27b3115 100644
> --- a/drivers/regulator/twl4030-regulator.c
> +++ b/drivers/regulator/twl4030-regulator.c
> @@ -126,7 +126,7 @@ static int twl4030reg_disable(struct regulator_dev *rdev)
>  	if (grp < 0)
>  		return grp;
>  
> -	grp &= ~P1_GRP;
> +	grp &= ~(P1_GRP & P2_GRP | P3_GRP);
>  	return twl4030reg_write(info, VREG_GRP, grp);
>  }
>  

Applied.

Thanks

Liam


  parent reply	other threads:[~2009-11-20 19:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-20 16:29 [PATCH 1/1] twl4030-regulator: Remove regulator from all groups when disabling Eduardo Valentin
2009-11-20 17:08 ` Eduardo Valentin
2009-11-20 19:07 ` Liam Girdwood [this message]
2009-11-23  7:08   ` Eduardo Valentin
2009-11-23 10:55     ` Liam Girdwood
  -- strict thread matches above, loose matches on Subject: below --
2009-11-20 17:15 Eduardo Valentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258744079.3640.435.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=Peter.De-Schrijver@nokia.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=eduardo.valentin@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox