From: Bruce Beare <bbeare1@gmail.com>
To: gregkh@suse.de
Cc: wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Bruce Beare <bbeare1@gmail.com>
Subject: [PATCH 3/3] cleanup: printk() warnings for including the facility level. cleanup: add a printk("\n") to terminate the print for the non-error case.
Date: Fri, 20 Nov 2009 15:46:11 -0800 [thread overview]
Message-ID: <1258760771-24311-4-git-send-email-bbeare1@gmail.com> (raw)
In-Reply-To: <1258760771-24311-3-git-send-email-bbeare1@gmail.com>
Signed-off-by: Bruce Beare <bbeare1@gmail.com>
---
drivers/staging/comedi/drivers/pcmad.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcmad.c b/drivers/staging/comedi/drivers/pcmad.c
index 787aea2..75b61a2 100644
--- a/drivers/staging/comedi/drivers/pcmad.c
+++ b/drivers/staging/comedi/drivers/pcmad.c
@@ -134,11 +134,12 @@ static int pcmad_attach(struct comedi_device *dev, struct comedi_devconfig *it)
unsigned long iobase;
iobase = it->options[0];
- printk("comedi%d: pcmad: 0x%04lx ", dev->minor, iobase);
+ printk(KERN_NOTICE "comedi%d: pcmad: 0x%04lx ", dev->minor, iobase);
if (!request_region(iobase, PCMAD_SIZE, "pcmad")) {
- printk("I/O port conflict\n");
+ printk(KERN_CONT "I/O port conflict\n");
return -EIO;
}
+ printk(KERN_CONT "\n");
dev->iobase = iobase;
ret = alloc_subdevices(dev, 1);
@@ -165,7 +166,7 @@ static int pcmad_attach(struct comedi_device *dev, struct comedi_devconfig *it)
static int pcmad_detach(struct comedi_device *dev)
{
- printk("comedi%d: pcmad: remove\n", dev->minor);
+ printk(KERN_NOTICE "comedi%d: pcmad: remove\n", dev->minor);
if (dev->irq)
free_irq(dev->irq, dev);
--
1.6.2.5
prev parent reply other threads:[~2009-11-20 23:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 23:46 [PATCH 0/3] checkpatch.pl cleanups for drivers/staging/comedi/drivers/pcmad.c Bruce Beare
2009-11-20 23:46 ` [PATCH 1/3] Cleanup: code indent warning messages (use tabs instead of leading spaces) Bruce Beare
2009-11-20 23:46 ` [PATCH 2/3] Cleanup: Remove unneeded braces (cleanup warning message) Bruce Beare
2009-11-20 23:46 ` Bruce Beare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258760771-24311-4-git-send-email-bbeare1@gmail.com \
--to=bbeare1@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox