From: Mike Galbraith <efault@gmx.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch] sched: add the other missing clock update to migrate_task()
Date: Sun, 22 Nov 2009 17:58:43 +0100 [thread overview]
Message-ID: <1258909123.6043.19.camel@marge.simson.net> (raw)
In-Reply-To: <1258895770.28730.528.camel@laptop>
On Sun, 2009-11-22 at 14:16 +0100, Peter Zijlstra wrote:
> We should make double_rq_lock() and double_lock_balance() behave
> equivalent wrt update_rq_clock().
>
> Current, depending on CONFIG_PREEMPT, double_lock_balance() already
> updates both rq clocks.
Hm, right. Better plan. We can save an update in the wakeup path for
the tasks racing for the wakeup case too. If the call is really a
lock/unlock go away, we don't need to bother. Shave a ns or so.
-Mike
next prev parent reply other threads:[~2009-11-22 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-22 12:11 [patch] sched: add the other missing clock update to migrate_task() Mike Galbraith
2009-11-22 13:16 ` Peter Zijlstra
2009-11-22 16:58 ` Mike Galbraith [this message]
2009-11-22 18:14 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258909123.6043.19.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox