From: Peter Zijlstra <peterz@infradead.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: newidle balancing in NUMA domain?
Date: Mon, 23 Nov 2009 12:50:45 +0100 [thread overview]
Message-ID: <1258977045.4531.317.camel@laptop> (raw)
In-Reply-To: <20091123114339.GB2287@wotan.suse.de>
On Mon, 2009-11-23 at 12:43 +0100, Nick Piggin wrote:
> On Mon, Nov 23, 2009 at 12:36:15PM +0100, Peter Zijlstra wrote:
> > IIRC this was kbuild and other spreading workloads that want this.
> >
> > the newidle_idx=0 thing is because I frequently saw it make funny
> > balance decisions based on old load numbers, like f_b_g() selecting a
> > group that didn't even have tasks in anymore.
>
> Well it is just a damping factor on runqueue flucturations. If the
> group recently had load then the point of the idx is to account
> for this. On the other hand, if we have other groups that are also
> above the idx damped average, it would make sense to use them
> instead. (ie. cull source groups with no pullable tasks).
Right, thing is, I'm still catching up from being gone, and haven't
actually read and tought through the whole rate-limiting thing :-(
If you see a better way to accomplish things, please holler.
> > We went without newidle for a while, but then people started complaining
> > about that kbuild time, and there is a x264 encoder thing that looses
> > tons of throughput.
>
> So... these were due to what? Other changes in domains balancing?
> Changes in CFS? Something else? Or were they comparisons versus
> other operating systems?
Comparison to Con's latest single-rq spread like there's no cache
affinity BFS thing.
next prev parent reply other threads:[~2009-11-23 11:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-23 11:22 newidle balancing in NUMA domain? Nick Piggin
2009-11-23 11:36 ` Peter Zijlstra
2009-11-23 11:43 ` Nick Piggin
2009-11-23 11:50 ` Peter Zijlstra [this message]
2009-11-23 12:16 ` Nick Piggin
2009-11-23 11:45 ` Ingo Molnar
2009-11-23 12:01 ` Nick Piggin
2009-11-23 12:08 ` Ingo Molnar
2009-11-23 12:27 ` Nick Piggin
2009-11-23 12:46 ` Ingo Molnar
2009-11-24 6:36 ` Nick Piggin
2009-11-24 17:24 ` Jason Garrett-Glaser
2009-11-24 18:09 ` Mike Galbraith
2009-11-30 8:19 ` Nick Piggin
2009-12-01 8:18 ` Jason Garrett-Glaser
2009-11-23 14:37 ` Mike Galbraith
2009-11-23 15:11 ` Nick Piggin
2009-11-23 15:21 ` Peter Zijlstra
2009-11-23 15:29 ` Nick Piggin
2009-11-23 15:37 ` Peter Zijlstra
2009-11-24 6:54 ` Nick Piggin
2009-11-23 15:53 ` Mike Galbraith
2009-11-24 6:53 ` Nick Piggin
2009-11-24 8:40 ` Mike Galbraith
2009-11-24 8:58 ` Mike Galbraith
2009-11-24 9:11 ` Ingo Molnar
2009-11-30 8:27 ` Nick Piggin
2009-11-23 17:04 ` Ingo Molnar
2009-11-24 6:59 ` Nick Piggin
2009-11-24 9:16 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258977045.4531.317.camel@laptop \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox