public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: peterz@infradead.org, torvalds@linux-foundation.org,
	awalls@radix.net, linux-kernel@vger.kernel.org, jeff@garzik.org,
	mingo@elte.hu, akpm@linux-foundation.org, jens.axboe@oracle.com,
	rusty@rustcorp.com.au, cl@linux-foundation.org,
	dhowells@redhat.com, arjan@linux.intel.com, avi@redhat.com,
	johannes@sipsolutions.net
Cc: Tejun Heo <tj@kernel.org>
Subject: [PATCH 01/14] sched, kvm: fix race condition involving sched_in_preempt_notifers
Date: Tue, 24 Nov 2009 01:26:51 +0900	[thread overview]
Message-ID: <1258993624-28735-2-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1258993624-28735-1-git-send-email-tj@kernel.org>

In finish_task_switch(), fire_sched_in_preempt_notifiers() is called
after finish_lock_switch().  However, depending on architecture,
preemption can be enabled after finish_lock_switch() which breaks the
semantics of preempt notifiers.  Move it before finish_arch_switch().
This also makes in notifiers symmetric to out notifiers in terms of
locking - now both are called under rq lock.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Avi Kivity <avi@redhat.com>
---
 kernel/sched.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 3c11ae0..de8a765 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -2751,9 +2751,9 @@ static void finish_task_switch(struct rq *rq, struct task_struct *prev)
 	prev_state = prev->state;
 	finish_arch_switch(prev);
 	perf_event_task_sched_in(current, cpu_of(rq));
+	fire_sched_in_preempt_notifiers(current);
 	finish_lock_switch(rq, prev);
 
-	fire_sched_in_preempt_notifiers(current);
 	if (mm)
 		mmdrop(mm);
 	if (unlikely(prev_state == TASK_DEAD)) {
-- 
1.6.5.3


  reply	other threads:[~2009-11-23 16:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-23 16:26 [PATCHSET] workqueue: prepare for concurrency managed workqueue, take#3 Tejun Heo
2009-11-23 16:26 ` Tejun Heo [this message]
2009-11-23 16:26 ` [PATCH 02/14] workqueue: Add debugobjects support Tejun Heo
2009-11-23 16:26 ` [PATCH 03/14] sched: rename preempt_notifier to sched_notifier and always enable it Tejun Heo
2009-11-23 16:26 ` [PATCH 04/14] sched: update sched_notifier and add wakeup/sleep notifications Tejun Heo
2009-11-23 16:26 ` [PATCH 05/14] sched: refactor try_to_wake_up() and implement try_to_wake_up_local() Tejun Heo
2009-11-23 16:26 ` [PATCH 06/14] sched: implement force_cpus_allowed() Tejun Heo
2009-11-23 16:26 ` [PATCH 07/14] acpi: use queue_work_on() instead of binding workqueue worker to cpu0 Tejun Heo
2009-11-23 16:26 ` [PATCH 08/14] stop_machine: reimplement without using workqueue Tejun Heo
2009-11-23 16:26 ` [PATCH 09/14] workqueue: misc/cosmetic updates Tejun Heo
2009-11-23 16:27 ` [PATCH 10/14] workqueue: merge feature parameters into flags Tejun Heo
2009-11-23 16:27 ` [PATCH 11/14] workqueue: update cwq alignement and make one more flag bit available Tejun Heo
2009-11-23 16:27 ` [PATCH 12/14] workqueue: define both bit position and mask for work flags Tejun Heo
2009-11-23 16:27 ` [PATCH 13/14] workqueue: separate out process_one_work() Tejun Heo
2009-11-23 16:27 ` [PATCH 14/14] workqueue: temporarily disable workqueue tracing Tejun Heo
2009-11-24 13:33 ` [PATCHSET] workqueue: prepare for concurrency managed workqueue, take#3 Avi Kivity
2009-11-25  7:38 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258993624-28735-2-git-send-email-tj@kernel.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@linux.intel.com \
    --cc=avi@redhat.com \
    --cc=awalls@radix.net \
    --cc=cl@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=jeff@garzik.org \
    --cc=jens.axboe@oracle.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox