Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]

David Howells
2005-03-10T12:50:24Z

Andrew Morton <akpm@osdl.org> wrote:

> What's with the preempt_enable()/disable() added to __key_link()? It's not
> obvious what is being protected from what, and why.

Ummm... Yes... They're probably not necessary. A wmb() may be required after
the klist->nkeys++ to commit to memory the fact there's now an extra key link
available, but I'm not sure that it's necessary.

Do you want me to redo the patch?

David