From: Peter Zijlstra <peterz@infradead.org>
To: eranian@gmail.com
Cc: Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu,
perfmon2-devel@lists.sf.net, eranian@google.com
Subject: Re: [PATCH] perf_events: fix validate_event bug
Date: Wed, 25 Nov 2009 08:55:57 +0100 [thread overview]
Message-ID: <1259135757.4027.5.camel@laptop> (raw)
In-Reply-To: <7c86c4470911242147u160008d4y50385cb348615df8@mail.gmail.com>
On Wed, 2009-11-25 at 06:47 +0100, stephane eranian wrote:
> It seems to me you have two ways of solving this:
> 1- push the algorithm to assign events to counters up in the generic code
> 2- have the generic code invoke all possible constraint sources on each group
2, is what it currently does.
Since we can only add a single event to a group at a time, and we know
the previous group was schedulable, we only need to validate the
constraints on the pmu of the new event.
next prev parent reply other threads:[~2009-11-25 7:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 14:51 [PATCH] perf_events: fix validate_event bug Stephane Eranian
2009-11-18 16:46 ` Peter Zijlstra
2009-11-23 13:34 ` stephane eranian
2009-11-23 13:45 ` Peter Zijlstra
2009-11-24 13:18 ` stephane eranian
2009-11-24 22:00 ` Paul Mackerras
2009-11-25 5:47 ` stephane eranian
2009-11-25 7:55 ` Peter Zijlstra [this message]
2009-11-24 13:27 ` Stephane Eranian
2009-11-24 19:03 ` [tip:perf/core] perf_events, x86: Fix " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259135757.4027.5.camel@laptop \
--to=peterz@infradead.org \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox