* [PATCH] JFFS2: min/max confusion?
@ 2009-11-21 15:34 Roel Kluin
2009-11-26 7:05 ` Artem Bityutskiy
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-11-21 15:34 UTC (permalink / raw)
To: David Woodhouse, linux-mtd, Andrew Morton, LKML
MAX_SUMMARY_SIZE was meant as a limit, not as a minimum
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
fs/jffs2/summary.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
unless I am mistaken?
diff --git a/fs/jffs2/summary.c b/fs/jffs2/summary.c
index 6caf1e1..800171d 100644
--- a/fs/jffs2/summary.c
+++ b/fs/jffs2/summary.c
@@ -23,7 +23,7 @@
int jffs2_sum_init(struct jffs2_sb_info *c)
{
- uint32_t sum_size = max_t(uint32_t, c->sector_size, MAX_SUMMARY_SIZE);
+ uint32_t sum_size = min_t(uint32_t, c->sector_size, MAX_SUMMARY_SIZE);
c->summary = kzalloc(sizeof(struct jffs2_summary), GFP_KERNEL);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] JFFS2: min/max confusion?
2009-11-21 15:34 [PATCH] JFFS2: min/max confusion? Roel Kluin
@ 2009-11-26 7:05 ` Artem Bityutskiy
0 siblings, 0 replies; 2+ messages in thread
From: Artem Bityutskiy @ 2009-11-26 7:05 UTC (permalink / raw)
To: Roel Kluin; +Cc: David Woodhouse, linux-mtd, Andrew Morton, LKML
On Sat, 2009-11-21 at 16:34 +0100, Roel Kluin wrote:
> MAX_SUMMARY_SIZE was meant as a limit, not as a minimum
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> fs/jffs2/summary.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> unless I am mistaken?
>
> diff --git a/fs/jffs2/summary.c b/fs/jffs2/summary.c
> index 6caf1e1..800171d 100644
> --- a/fs/jffs2/summary.c
> +++ b/fs/jffs2/summary.c
> @@ -23,7 +23,7 @@
>
> int jffs2_sum_init(struct jffs2_sb_info *c)
> {
> - uint32_t sum_size = max_t(uint32_t, c->sector_size, MAX_SUMMARY_SIZE);
> + uint32_t sum_size = min_t(uint32_t, c->sector_size, MAX_SUMMARY_SIZE);
>
> c->summary = kzalloc(sizeof(struct jffs2_summary), GFP_KERNEL);
This looks right, I've pushed your patch to my l2-mtd tree, thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-26 7:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-21 15:34 [PATCH] JFFS2: min/max confusion? Roel Kluin
2009-11-26 7:05 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).