From: Peter Zijlstra <peterz@infradead.org>
To: Mike Galbraith <efault@gmx.de>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch] sched: fix set_task_cpu() and provide an unlocked runqueue variant
Date: Thu, 26 Nov 2009 15:09:23 +0100 [thread overview]
Message-ID: <1259244563.31676.53.camel@laptop> (raw)
In-Reply-To: <1259230578.15079.12.camel@marge.simson.net>
On Thu, 2009-11-26 at 11:16 +0100, Mike Galbraith wrote:
> > min_vruntime should only ever be poked at when holding the respective
> > rq->lock, even with a barrier a 64bit read on a 32bit machine can go all
> > funny.
>
> Yeah, but we're looking at an unlocked runqueue. But never mind...
The patch is also poking at rq->clock without rq->lock held... not very
nice.
Gah, I hate that we're doing migration things without holding both rq's,
this is making live so very interesting ;-)
next prev parent reply other threads:[~2009-11-26 14:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-22 12:09 [patch] sched: fix set_task_cpu() and provide an unlocked runqueue variant Mike Galbraith
2009-11-25 18:27 ` Peter Zijlstra
2009-11-26 1:01 ` Mike Galbraith
2009-11-26 1:31 ` Mike Galbraith
2009-11-26 9:35 ` Peter Zijlstra
2009-11-26 10:16 ` Mike Galbraith
2009-11-26 14:09 ` Peter Zijlstra [this message]
2009-11-26 14:21 ` Peter Zijlstra
2009-11-26 15:32 ` Mike Galbraith
2009-11-26 14:58 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259244563.31676.53.camel@laptop \
--to=peterz@infradead.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox