From: Matthias Urlichs <matthias@urlichs.de>
To: Gernot Hillier <gernot@hillier.de>
Cc: Oliver Neukum <oliver@neukum.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add support for Mobilcom Debitel USB UMTS Surf-Stick to option driver
Date: Fri, 27 Nov 2009 14:24:14 +0100 [thread overview]
Message-ID: <1259328254.27675.524.camel@kiste> (raw)
In-Reply-To: <4B0FCAD3.9000801@hillier.de>
On Fri, 2009-11-27 at 13:49 +0100, Gernot Hillier wrote:
> + /* 4G Systems W14 simply ignores this message on interface 0 & 1
> + and would cause long timeouts when calling usb_control_msg() */
> + if (serial->dev->descriptor.idVendor == FOUR_G_SYSTEMS_VENDOR_ID &&
> + serial->dev->descriptor.idProduct == FOUR_G_SYSTEMS_PRODUCT_W14 &&
> + (ifNum == 0 || ifNum == 1) )
> + return -EIO;
>
I'd appreciate if you'd implement this generically.
I.e., use the driver_info field of struct usb_device for an appropriate
blacklist flag. (It's not going to be the only one.)
next prev parent reply other threads:[~2009-11-27 13:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-22 8:08 [PATCH] Add support for Mobilcom Debitel USB UMTS Surf-Stick to option driver Gernot Hillier
2009-11-22 8:20 ` Oliver Neukum
2009-11-24 18:00 ` Gernot Hillier
2009-11-24 18:19 ` Oliver Neukum
2009-11-27 12:49 ` Gernot Hillier
2009-11-27 13:24 ` Matthias Urlichs [this message]
2009-11-27 18:11 ` Gernot Hillier
2009-11-27 18:53 ` Greg KH
2009-12-08 6:20 ` Gernot Hillier
2009-12-08 7:34 ` Matthias Urlichs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259328254.27675.524.camel@kiste \
--to=matthias@urlichs.de \
--cc=gernot@hillier.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox