Re: [RFC][PATCH 0/7] perf trace: general-purpose scripting support, v2

[Tom Zanussi <tzanussi@gmail.com>]

On Sat, 2009-11-28 at 10:14 +0100, Ingo Molnar wrote:
> * Tom Zanussi <tzanussi@gmail.com> wrote:
> 
> > Hi,
> > 
> > Here's a belated update to v1 of the trace stream scripting support 
> > patches I posted last month; I had meant to get this out sooner but 
> > got too busy with other things...
> 
> Excellent progress!
> 
> I wanted to try it so i took the patches and applied them with some 
> conflicts (they interacted with some other recent changes in perf), but 
> the Perl engine wouldnt build on Fedora 11 - see the errors attached 
> below.
> 
> I've pushed the merge out to this temporary branch:
> 
>   git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git tmp.perf/scripting
> 
> Mind having a look at it?
> 

Sure, I'll post a patch that fixes this for me on Fedora shortly - the
reason for the warnings is that the debugging versions of the Perl
macros used in trace-event-perl.c get pulled in in Fedora (I did 'yum
install perl-ExtUtils-Embed' to get the libperl support), and the
debugging code generated by them shadows a global variable.  Since the
code should work in the debugging case regardless, and since I don't
have control over the code in the macros, I don't see much choice in
this case but to ignore the warning.

I'll also post a few other fixes for things I noticed when fixing this.

Tom

> Thanks,
> 
> 	Ingo
> 
>     CC util/trace-event-perl.o
> cc1: warnings being treated as errors
> util/trace-event-perl.c: In function 'define_symbolic_value':
> util/trace-event-perl.c:70: error: declaration of 'my_perl' shadows a global declaration
> util/trace-event-perl.c:48: error: shadowed declaration is here
> util/trace-event-perl.c:85: error: declaration of 'my_perl' shadows a global declaration
> util/trace-event-perl.c:48: error: shadowed declaration is here
> util/trace-event-perl.c: In function 'define_symbolic_field':
> util/trace-event-perl.c:102: error: declaration of 'my_perl' shadows a global declaration
> util/trace-event-perl.c:48: error: shadowed declaration is here
> util/trace-event-perl.c:115: error: declaration of 'my_perl' shadows a global declaration
> util/trace-event-perl.c:48: error: shadowed declaration is here
> util/trace-event-perl.c: In function 'define_flag_value':
> util/trace-event-perl.c:128: error: declaration of 'my_perl' shadows a global declaration
> util/trace-event-perl.c:48: error: shadowed declaration is here
> util/trace-event-perl.c:143: error: declaration of 'my_perl' shadows a global declaration
> util/trace-event-perl.c:48: error: shadowed declaration is here
> util/trace-event-perl.c: In function 'define_flag_field':
> util/trace-event-perl.c:161: error: declaration of 'my_perl' shadows a global declaration
> util/trace-event-perl.c:48: error: shadowed declaration is here
> util/trace-event-perl.c:175: error: declaration of 'my_perl' shadows a global declaration
> util/trace-event-perl.c:48: error: shadowed declaration is here
> util/trace-event-perl.c: In function 'perl_process_event':
> util/trace-event-perl.c:301: error: declaration of 'my_perl' shadows a global declaration
> util/trace-event-perl.c:48: error: shadowed declaration is here
> util/trace-event-perl.c:350: error: declaration of 'my_perl' shadows a global declaration
> util/trace-event-perl.c:48: error: shadowed declaration is here
> make: *** [util/trace-event-perl.o] Error 1