From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Mackerras <paulus@samba.org>,
Prasad <prasad@linux.vnet.ibm.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Will Deacon <will.deacon@arm.com>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH 2/2] hw-breakpoints: Add two reserved fields for future extensions
Date: Thu, 03 Dec 2009 22:33:39 +0100 [thread overview]
Message-ID: <1259876019.3977.1559.camel@laptop> (raw)
In-Reply-To: <1259874964-7757-2-git-send-regression-fweisbec@gmail.com>
On Thu, 2009-12-03 at 22:16 +0100, Frederic Weisbecker wrote:
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 771d04c..89832cc 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -221,6 +221,8 @@ struct perf_event_attr {
> __u64 bp_end;
> __u32 bp_type;
> __u32 bp_len;
> + __u64 __bp_reserved_1;
> + __u64 __bp_reserved_2;
> };
> };
Looking at that code I see:
union {
struct {
}
}
wth is that union for?
next prev parent reply other threads:[~2009-12-03 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 21:16 [PATCH 1/2] hw-breakpoints: Perf interface support for breakpoint ranges Frederic Weisbecker
2009-12-03 21:16 ` [PATCH 2/2] hw-breakpoints: Add two reserved fields for future extensions Frederic Weisbecker
2009-12-03 21:33 ` Peter Zijlstra [this message]
2009-12-03 22:20 ` [PATCH] perf: Remove pointless union that wraps the hw breakpoint fields Frederic Weisbecker
2009-12-04 3:08 ` [PATCH 1/2] hw-breakpoints: Perf interface support for breakpoint ranges Benjamin Herrenschmidt
2009-12-04 21:00 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259876019.3977.1559.camel@laptop \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=fweisbec@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=prasad@linux.vnet.ibm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox