From: Peter Zijlstra <peterz@infradead.org>
To: ehrhardt@linux.vnet.ibm.com
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org,
Holger.Wolf@de.ibm.com, epasch@de.ibm.com,
schwidefsky@de.ibm.com
Subject: Re: [PATCH 3/3] sched: update normalized values on user updates via proc v2
Date: Fri, 04 Dec 2009 10:49:12 +0100 [thread overview]
Message-ID: <1259920152.3977.1820.camel@laptop> (raw)
In-Reply-To: <1259579808-11357-4-git-send-email-ehrhardt@linux.vnet.ibm.com>
On Mon, 2009-11-30 at 12:16 +0100, ehrhardt@linux.vnet.ibm.com wrote:
> @@ -301,7 +303,9 @@ static struct ctl_table kern_table[] = {
> .data = &sysctl_sched_shares_ratelimit,
> .maxlen = sizeof(unsigned int),
> .mode = 0644,
> - .proc_handler = &proc_dointvec,
> + .proc_handler = &sched_proc_update_handler,
> + .extra1 = &min_sched_shares_ratelimit,
> + .extra2 = &max_sched_shares_ratelimit,
> },
While I don't object to that change it really should have been a
separate patch.
And at the very least the changelog should have said something about it.
Anyway, took all 3 patches.
next prev parent reply other threads:[~2009-12-04 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 11:16 [PATCH 0/3] fix rescaling of scheduler tunables v2 ehrhardt
2009-11-30 11:16 ` [PATCH 1/3] sched: fix missing sched tunable recalculation on cpu add/remove ehrhardt
2009-12-04 9:49 ` Peter Zijlstra
2009-12-09 9:56 ` [tip:sched/urgent] sched: Fix " tip-bot for Christian Ehrhardt
2009-11-30 11:16 ` [PATCH 2/3] sched: make tunable scaling style configurable ehrhardt
2009-12-04 9:49 ` Peter Zijlstra
2009-12-09 9:56 ` [tip:sched/urgent] sched: Make " tip-bot for Christian Ehrhardt
2009-11-30 11:16 ` [PATCH 3/3] sched: update normalized values on user updates via proc v2 ehrhardt
2009-12-04 9:49 ` Peter Zijlstra [this message]
2009-12-09 9:56 ` [tip:sched/urgent] sched: Update normalized values on user updates via proc tip-bot for Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259920152.3977.1820.camel@laptop \
--to=peterz@infradead.org \
--cc=Holger.Wolf@de.ibm.com \
--cc=ehrhardt@linux.vnet.ibm.com \
--cc=epasch@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox