From: Mike Galbraith <efault@gmx.de>
To: Suresh Jayaraman <sjayaraman@suse.de>
Cc: mingo@elte.hu, Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] sched: fix GENTLE_FAIR_SLEEPERS dependency
Date: Fri, 04 Dec 2009 11:06:27 +0100 [thread overview]
Message-ID: <1259921187.15613.21.camel@marge.simson.net> (raw)
In-Reply-To: <4B18D66E.8020905@suse.de>
On Fri, 2009-12-04 at 14:59 +0530, Suresh Jayaraman wrote:
> The newly introduced GENTLE_FAIR_SLEEPERS does not seem to have any
> effect without FAIR_SLEEPERS. Fix sysctl.sched_features to reflect
> this. Without this change, a user who sets GENTLE_FAIR_SLEEPERS
> without FAIR_SLEEPERS would assume gentle sleeper fairness which
> is not guaranteed.
IMHO, these dependencies belong in documentation, not enforcement code.
Same applies for LAST_BUDDY, meaningless without WAKEUP_PREEMPT.
SYNC_MORE, SYNC_LESS + AFFINE_WAKEUPS etc.
Bottom line for all button poking and knob turning is you'd better make
sure you know what button/knob does, and what other things may depend on
it before messing with it, lest you get a nasty surprise.
-Mike
prev parent reply other threads:[~2009-12-04 10:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 9:29 [RFC][PATCH] sched: fix GENTLE_FAIR_SLEEPERS dependency Suresh Jayaraman
2009-12-04 9:54 ` Ingo Molnar
2009-12-04 10:20 ` Suresh Jayaraman
2009-12-04 11:08 ` Peter Zijlstra
2009-12-04 11:12 ` Peter Zijlstra
2009-12-04 11:42 ` Suresh Jayaraman
2009-12-04 12:08 ` Peter Zijlstra
2009-12-04 13:12 ` Suresh Jayaraman
2009-12-04 13:12 ` Mike Galbraith
2009-12-04 10:06 ` Mike Galbraith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259921187.15613.21.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=sjayaraman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox