From: Peter Zijlstra <peterz@infradead.org>
To: bharata@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org,
Dhaval Giani <dhaval@linux.vnet.ibm.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
Gautham R Shenoy <ego@in.ibm.com>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
Ingo Molnar <mingo@elte.hu>, Pavel Emelyanov <xemul@openvz.org>,
Herbert Poetzl <herbert@13thfloor.at>,
Avi Kivity <avi@redhat.com>, Chris Friesen <cfriesen@nortel.com>,
Paul Menage <menage@google.com>,
Mike Waychison <mikew@google.com>
Subject: Re: [RFC v4 PATCH 6/7] sched: Rebalance cfs runtimes
Date: Fri, 04 Dec 2009 17:09:58 +0100 [thread overview]
Message-ID: <1259942998.17907.897.camel@laptop> (raw)
In-Reply-To: <20091117143718.GQ17335@in.ibm.com>
On Tue, 2009-11-17 at 20:07 +0530, Bharata B Rao wrote:
> sched: CFS runtime borrowing
>
> From: Bharata B Rao <bharata@linux.vnet.ibm.com>
>
> Before throttling a group, try to borrow runtime from groups that have excess.
>
> To start with, a group will get equal runtime on every cpu. If the group doesn't
> have tasks on all cpus, it might get throttled on some cpus while it still has
> runtime left on other cpus where it doesn't have any tasks to consume that
> runtime. Hence there is a chance to borrow runtimes from such cpus/cfs_rqs to
> cpus/cfs_rqs where it is required.
>
> CHECK: RT seems to be handling runtime initialization/reclaim during hotplug
> from multiple places (migration_call, update_runtime). Need to check if CFS
> also needs to do the same.
>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> ---
> kernel/sched.c | 26 ++++++++
> kernel/sched_fair.c | 172 +++++++++++++++++++++++++++++++++++++++++++++++++++
> kernel/sched_rt.c | 26 +-------
> 3 files changed, 202 insertions(+), 22 deletions(-)
I think that if we unify the se/rq bandwidth structures a lot of copy
and paste can be avoided, resulting in an over-all much easier to
maintain code-base.
next prev parent reply other threads:[~2009-12-04 16:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-17 14:33 [RFC v4 PATCH 0/7] CFS Hard limits - v4 Bharata B Rao
2009-11-17 14:34 ` [RFC v4 PATCH 1/7] sched: Rename sched_rt_period_mask() and use it in CFS also Bharata B Rao
2009-11-17 14:34 ` [RFC v4 PATCH 2/7] sched: Bandwidth initialization for fair task groups Bharata B Rao
2009-12-04 16:09 ` Peter Zijlstra
2009-12-04 16:09 ` Peter Zijlstra
2009-12-05 13:04 ` Bharata B Rao
2009-11-17 14:35 ` [RFC v4 PATCH 3/7] sched: Enforce hard limits by throttling Bharata B Rao
2009-12-04 16:09 ` Peter Zijlstra
2009-12-05 13:02 ` Bharata B Rao
2009-11-17 14:35 ` [RFC v4 PATCH 4/7] sched: Unthrottle the throttled tasks Bharata B Rao
2009-11-17 14:36 ` [RFC v4 PATCH 5/7] sched: Add throttle time statistics to /proc/sched_debug Bharata B Rao
2009-11-17 14:37 ` [RFC v4 PATCH 6/7] sched: Rebalance cfs runtimes Bharata B Rao
2009-12-04 16:09 ` Peter Zijlstra [this message]
2009-12-05 13:08 ` Bharata B Rao
2009-11-17 14:37 ` [RFC v4 PATCH 7/7] sched: Hard limits documentation Bharata B Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259942998.17907.897.camel@laptop \
--to=peterz@infradead.org \
--cc=avi@redhat.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=cfriesen@nortel.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=ego@in.ibm.com \
--cc=herbert@13thfloor.at \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
--cc=mikew@google.com \
--cc=mingo@elte.hu \
--cc=svaidy@linux.vnet.ibm.com \
--cc=vatsa@in.ibm.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox