From: Eric Paris <eparis@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org, dhowells@redhat.com,
gyang@blackfin.uclinux.org, john.johansen@canonical.com,
Mike Frysinger <vapier.adi@gmail.com>,
stable@kernel.org
Subject: Re: [PATCH] security: do not check mmap_min_addr on nommu systems
Date: Fri, 04 Dec 2009 15:01:52 -0500 [thread overview]
Message-ID: <1259956912.2722.47.camel@localhost> (raw)
In-Reply-To: <20091203115858.d91b64dc.akpm@linux-foundation.org>
On Thu, 2009-12-03 at 11:58 -0800, Andrew Morton wrote:
> On Thu, 03 Dec 2009 14:43:01 -0500
> Eric Paris <eparis@redhat.com> wrote:
>
> > nommu systems can do anything with memory they please and so they already
> > win. mmap_min_addr is the least of their worries. Currently the
> > mmap_min_addr implementation is problamatic on such systems. This patch
> > changes the addr_only argument to be a flags which can take the arguments
> > for addr_only or not_addr. LSMs then need to properly implement these two
> > flags.
>
> This replaces David's
> nommu-ignore-the-address-parameter-in-the-file_mmap-security-check.patch,
> which missed 2.6.32.
>
> What are our thoughts wrt backporting this fix in some form into
> 2.6.32.x and earlier?
It would be very simple to do if anyone really wanted it. Seems the
only people who hit the problem already are happy with their temporary
hack. If anyone is actually hitting this bug, would actually update to
a stable kernel to get the fix, and would like me to send it that way
let me know and I will.
-Eric
next prev parent reply other threads:[~2009-12-04 20:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 19:43 [PATCH] security: do not check mmap_min_addr on nommu systems Eric Paris
2009-12-03 19:58 ` Andrew Morton
2009-12-04 20:01 ` Eric Paris [this message]
2009-12-04 10:52 ` David Howells
2009-12-04 21:55 ` David Howells
2009-12-04 22:44 ` John Johansen
-- strict thread matches above, loose matches on Subject: below --
2009-12-05 3:26 Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1259956912.2722.47.camel@localhost \
--to=eparis@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=gyang@blackfin.uclinux.org \
--cc=john.johansen@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stable@kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox