From: Brian Gerst <brgerst@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/5] x86: Sync 32/64-bit kernel_thread
Date: Wed, 9 Dec 2009 12:34:43 -0500 [thread overview]
Message-ID: <1260380084-3707-5-git-send-email-brgerst@gmail.com> (raw)
In-Reply-To: <1260380084-3707-1-git-send-email-brgerst@gmail.com>
Signed-off-by: Brian Gerst <brgerst@gmail.com>
---
arch/x86/kernel/process_32.c | 5 ++++-
arch/x86/kernel/process_64.c | 11 +++++++++--
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/process_32.c b/arch/x86/kernel/process_32.c
index ee0d4bc..e45aa22 100644
--- a/arch/x86/kernel/process_32.c
+++ b/arch/x86/kernel/process_32.c
@@ -211,14 +211,17 @@ int kernel_thread(int (*fn)(void *), void *arg, unsigned long flags)
regs.si = (unsigned long) fn;
regs.di = (unsigned long) arg;
+#ifdef CONFIG_X86_32
regs.ds = __USER_DS;
regs.es = __USER_DS;
regs.fs = __KERNEL_PERCPU;
regs.gs = __KERNEL_STACK_CANARY;
+#endif
+
regs.orig_ax = -1;
regs.ip = (unsigned long) kernel_thread_helper;
regs.cs = __KERNEL_CS | get_kernel_rpl();
- regs.flags = X86_EFLAGS_IF | X86_EFLAGS_SF | X86_EFLAGS_PF | 0x2;
+ regs.flags = X86_EFLAGS_IF | 0x2;
/* Ok, create the new process.. */
return do_fork(flags | CLONE_VM | CLONE_UNTRACED, 0, ®s, 0, NULL, NULL);
diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
index 1d8b03d..54c9939 100644
--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@ -248,10 +248,17 @@ int kernel_thread(int (*fn)(void *), void *arg, unsigned long flags)
regs.si = (unsigned long) fn;
regs.di = (unsigned long) arg;
+#ifdef CONFIG_X86_32
+ regs.ds = __USER_DS;
+ regs.es = __USER_DS;
+ regs.fs = __KERNEL_PERCPU;
+ regs.gs = __KERNEL_STACK_CANARY;
+#endif
+
regs.orig_ax = -1;
regs.ip = (unsigned long) kernel_thread_helper;
- regs.cs = __KERNEL_CS;
- regs.flags = X86_EFLAGS_IF;
+ regs.cs = __KERNEL_CS | get_kernel_rpl();
+ regs.flags = X86_EFLAGS_IF | 0x2;
/* Ok, create the new process.. */
return do_fork(flags | CLONE_VM | CLONE_UNTRACED, 0, ®s, 0, NULL, NULL);
--
1.6.5.2
next prev parent reply other threads:[~2009-12-09 17:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 17:34 [PATCH 0/5] x86: Merge kernel_thread() Brian Gerst
2009-12-09 17:34 ` [PATCH 1/5] x86, 64-bit: Move kernel_thread to C Brian Gerst
2009-12-11 0:45 ` [tip:x86/asm] " tip-bot for Brian Gerst
2009-12-09 17:34 ` [PATCH 2/5] x86, 64-bit: Use user_mode() to determine new stack pointer in copy_thread() Brian Gerst
2009-12-11 0:45 ` [tip:x86/asm] " tip-bot for Brian Gerst
2009-12-09 17:34 ` [PATCH 3/5] x86, 32-bit: Use same regs as 64-bit for kernel_thread_helper Brian Gerst
2009-12-11 0:46 ` [tip:x86/asm] " tip-bot for Brian Gerst
2009-12-09 17:34 ` Brian Gerst [this message]
2009-12-11 0:46 ` [tip:x86/asm] x86: Sync 32/64-bit kernel_thread tip-bot for Brian Gerst
2009-12-09 17:34 ` [PATCH 5/5] x86: Merge kernel_thread() Brian Gerst
2009-12-11 0:46 ` [tip:x86/asm] " tip-bot for Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260380084-3707-5-git-send-email-brgerst@gmail.com \
--to=brgerst@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox