* [PATCH] timeriomem-rng.c: use resource_size()
@ 2009-12-11 1:16 H Hartley Sweeten
2009-12-11 1:34 ` Matt Mackall
2009-12-11 14:32 ` Alexander Clouter
0 siblings, 2 replies; 4+ messages in thread
From: H Hartley Sweeten @ 2009-12-11 1:16 UTC (permalink / raw)
To: kernel list; +Cc: Alexander Clouter
Use resource_size() for ioremap.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Alexander Clouter <alex@digriz.org.uk>
---
diff --git a/drivers/char/hw_random/timeriomem-rng.c b/drivers/char/hw_random/timeriomem-rng.c
index a94e930..a8428e6 100644
--- a/drivers/char/hw_random/timeriomem-rng.c
+++ b/drivers/char/hw_random/timeriomem-rng.c
@@ -100,8 +100,7 @@ static int __devinit timeriomem_rng_probe(struct platform_device *pdev)
timeriomem_rng_data = pdev->dev.platform_data;
- timeriomem_rng_data->address = ioremap(res->start,
- res->end - res->start + 1);
+ timeriomem_rng_data->address = ioremap(res->start, resource_size(res));
if (!timeriomem_rng_data->address)
return -EIO;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] timeriomem-rng.c: use resource_size()
2009-12-11 1:16 [PATCH] timeriomem-rng.c: use resource_size() H Hartley Sweeten
@ 2009-12-11 1:34 ` Matt Mackall
2009-12-11 15:15 ` Herbert Xu
2009-12-11 14:32 ` Alexander Clouter
1 sibling, 1 reply; 4+ messages in thread
From: Matt Mackall @ 2009-12-11 1:34 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: kernel list, Alexander Clouter, Herbert Xu
On Thu, 2009-12-10 at 20:16 -0500, H Hartley Sweeten wrote:
> Use resource_size() for ioremap.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Alexander Clouter <alex@digriz.org.uk>
(Generally speaking, it's best to cc: obscure stuff to a maintainer.)
Looks good to me. Herbert?
Signed-off-by: Matt Mackall <mpm@selenic.com>
> ---
>
> diff --git a/drivers/char/hw_random/timeriomem-rng.c b/drivers/char/hw_random/timeriomem-rng.c
> index a94e930..a8428e6 100644
> --- a/drivers/char/hw_random/timeriomem-rng.c
> +++ b/drivers/char/hw_random/timeriomem-rng.c
> @@ -100,8 +100,7 @@ static int __devinit timeriomem_rng_probe(struct platform_device *pdev)
>
> timeriomem_rng_data = pdev->dev.platform_data;
>
> - timeriomem_rng_data->address = ioremap(res->start,
> - res->end - res->start + 1);
> + timeriomem_rng_data->address = ioremap(res->start, resource_size(res));
> if (!timeriomem_rng_data->address)
> return -EIO;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
http://selenic.com : development and support for Mercurial and Linux
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] timeriomem-rng.c: use resource_size()
2009-12-11 1:16 [PATCH] timeriomem-rng.c: use resource_size() H Hartley Sweeten
2009-12-11 1:34 ` Matt Mackall
@ 2009-12-11 14:32 ` Alexander Clouter
1 sibling, 0 replies; 4+ messages in thread
From: Alexander Clouter @ 2009-12-11 14:32 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: kernel list
Hi,
* H Hartley Sweeten <hartleys@visionengravers.com> [2009-12-10 20:16:54-0500]:
>
> Use resource_size() for ioremap.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Alexander Clouter <alex@digriz.org.uk>
>
Acked-by: Alexander Clouter <alex@digriz.org.uk>
> diff --git a/drivers/char/hw_random/timeriomem-rng.c b/drivers/char/hw_random/timeriomem-rng.c
> index a94e930..a8428e6 100644
> --- a/drivers/char/hw_random/timeriomem-rng.c
> +++ b/drivers/char/hw_random/timeriomem-rng.c
> @@ -100,8 +100,7 @@ static int __devinit timeriomem_rng_probe(struct platform_device *pdev)
>
> timeriomem_rng_data = pdev->dev.platform_data;
>
> - timeriomem_rng_data->address = ioremap(res->start,
> - res->end - res->start + 1);
> + timeriomem_rng_data->address = ioremap(res->start, resource_size(res));
> if (!timeriomem_rng_data->address)
> return -EIO;
--
Alexander Clouter
.sigmonster says: Every time I think I know where it's at, they move it.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] timeriomem-rng.c: use resource_size()
2009-12-11 1:34 ` Matt Mackall
@ 2009-12-11 15:15 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2009-12-11 15:15 UTC (permalink / raw)
To: Matt Mackall; +Cc: H Hartley Sweeten, kernel list, Alexander Clouter
On Thu, Dec 10, 2009 at 07:34:43PM -0600, Matt Mackall wrote:
> On Thu, 2009-12-10 at 20:16 -0500, H Hartley Sweeten wrote:
> > Use resource_size() for ioremap.
> >
> > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> > Cc: Alexander Clouter <alex@digriz.org.uk>
>
> (Generally speaking, it's best to cc: obscure stuff to a maintainer.)
>
> Looks good to me. Herbert?
>
> Signed-off-by: Matt Mackall <mpm@selenic.com>
Patch applied. Thanks!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-12-11 15:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-11 1:16 [PATCH] timeriomem-rng.c: use resource_size() H Hartley Sweeten
2009-12-11 1:34 ` Matt Mackall
2009-12-11 15:15 ` Herbert Xu
2009-12-11 14:32 ` Alexander Clouter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox