Re: [PATCH 3/3] gpiolib: use chip->names for symlinks, always use gpioN for device names

Greg KH
2009-12-11T03:47:34Z

On Thu, Dec 10, 2009 at 07:39:30PM -0800, David Brownell wrote:
> On Wednesday 09 December 2009, Jani Nikula wrote:
> > While the device names are now unique again, collisions in chip->names
> > will still prevent duplicates from being exported to sysfs.
>
> That's why I was never a real fan of chip->names...
>
> IMO a "good" solution in this space needs to accept that
> those names are not going to be globally unique ... but
> that they'll be unique within some context, of necessity.
>
> If Greg doesn't want to see those names under classes,
> so be it ... but where should they then appear?

As a sysfs file within the device directory called 'name'? Then just
grep through the tree to find the right device, that also handles
duplicates just fine, right?

thanks,

greg k-h