From: Matt Mackall <mpm@selenic.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Rusty Russell <rusty@rustcorp.com.au>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
samr@ravnborg.org
Subject: Re: hwrng: virtio - Rename driver object to remove section mismatch warning
Date: Fri, 11 Dec 2009 18:33:17 -0600 [thread overview]
Message-ID: <1260577997.24459.1405.camel@calx> (raw)
In-Reply-To: <20091212002148.GA9586@merkur.ravnborg.org>
On Sat, 2009-12-12 at 01:21 +0100, Sam Ravnborg wrote:
> On Fri, Dec 11, 2009 at 12:08:49PM -0800, Randy Dunlap wrote:
> > On Fri, 11 Dec 2009 13:25:57 -0600 Matt Mackall wrote:
> >
> > > On Fri, 2009-12-11 at 23:36 +0800, Herbert Xu wrote:
> > > > Hi:
> > > >
> > > > Finally found the cause of the section mismatch warning in hwrng.
> > > > Apparently in addition to __devexit_p we now have to name the
> > > > variable in a certain way.
> > >
> > > That's fairly appalling. Any idea why?
> >
> > (I haven't read the rest of this thread..)
> >
> > scripts/mod/modpost.c looks for certain variable names to identify
> > variables that can have references to other (non-data) sections.
> > It's mostly explained there.
>
> Another option is to annotate the relevant variable.
Ok, I guess I knew about the annotations. So I take it the name magic
exists just for convenience or to hit the common cases?
--
http://selenic.com : development and support for Mercurial and Linux
next prev parent reply other threads:[~2009-12-12 0:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-11 15:36 hwrng: virtio - Rename driver object to remove section mismatch warning Herbert Xu
2009-12-11 19:25 ` Matt Mackall
2009-12-11 20:08 ` Randy Dunlap
2009-12-12 0:21 ` Sam Ravnborg
2009-12-12 0:33 ` Matt Mackall [this message]
2009-12-12 7:21 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260577997.24459.1405.camel@calx \
--to=mpm@selenic.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rusty@rustcorp.com.au \
--cc=sam@ravnborg.org \
--cc=samr@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox