public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: "Arve Hjønnevåg" <arve@android.com>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
	a.p.zijlstra@chello.nl, tglx@linutronix.de,
	pwil3058@bigpond.net.au, mingo@elte.hu,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/urgent] sched: Set correct normal_prio and prio values  in sched_fork()
Date: Sat, 12 Dec 2009 07:07:35 +0100	[thread overview]
Message-ID: <1260598055.6306.1.camel@marge.simson.net> (raw)
In-Reply-To: <d6200be20912112155w6eca7452x550bc77330f236b0@mail.gmail.com>

On Fri, 2009-12-11 at 21:55 -0800, Arve Hjønnevåg wrote:
> On Mon, Oct 5, 2009 at 3:47 AM, tip-bot for Peter Williams
> <pwil3058@bigpond.net.au> wrote:
> > Commit-ID:  f83f9ac2632732bd1678150b5a03d152f912fe72
> > Gitweb:     http://git.kernel.org/tip/f83f9ac2632732bd1678150b5a03d152f912fe72
> > Author:     Peter Williams <pwil3058@bigpond.net.au>
> > AuthorDate: Thu, 24 Sep 2009 06:47:10 +0000
> > Committer:  Ingo Molnar <mingo@elte.hu>
> > CommitDate: Mon, 5 Oct 2009 13:42:20 +0200
> >
> > sched: Set correct normal_prio and prio values in sched_fork()
> >
> > normal_prio should be updated if policy changes from RT to
> > SCHED_MORMAL or if static_prio/nice is changed.
> >
> > Some paths through sched_fork() ignore this requirement and may
> > result in normal_prio having an invalid value.
> >
> > Fixing this issue allows the call to effective_prio() in
> > wake_up_new_task() to be removed.
> >
> 
> This change causes a lot of threads with a 0 nice value to get a prio
> value of 140 instead of 120 (at least on my android arm msm build). I
> don't know if this has any impact on how they are scheduled since the
> load weight is unaffected, but it at least makes the output of ps more
> confusing.

There's a patch in tip to correct this, hasn't swam upstream yet.

	-Mike


  reply	other threads:[~2009-12-12  6:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-24  6:47 [PATCH] sched: Set correct normal_prio and prio values in sched_fork() Peter Williams
2009-10-05 11:20 ` Peter Zijlstra
2009-10-05 11:47 ` [tip:sched/urgent] " tip-bot for Peter Williams
2009-12-12  5:55   ` Arve Hjønnevåg
2009-12-12  6:07     ` Mike Galbraith [this message]
2009-12-12  6:16       ` Ingo Molnar
2009-12-15  4:19         ` Arve Hjønnevåg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260598055.6306.1.camel@marge.simson.net \
    --to=efault@gmx.de \
    --cc=a.p.zijlstra@chello.nl \
    --cc=arve@android.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=pwil3058@bigpond.net.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox