From: Peter Zijlstra <peterz@infradead.org>
To: Joe Perches <joe@perches.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/14] kernel/exit.c and kernel/panic.c: Remove unused NORET_TYPE
Date: Wed, 16 Dec 2009 19:51:55 +0100 [thread overview]
Message-ID: <1260989515.21028.228.camel@laptop> (raw)
In-Reply-To: <29e53e769a3f0b38ea8347b95c8947d3f50ab4c6.1260949674.git.joe@perches.com>
On Wed, 2009-12-16 at 00:09 -0800, Joe Perches wrote:
> Make the functions match the prototypes in <linux/kernel.h>
> It's defined to nothing and useless
Uhm, why not make it useful again and define it to something like:
#define NORET_TYPE __attribute__((noreturn))
except I guess that should come after the function name, not before.
Annotations that tell a particular function is not supposed to exit
seems useful to me..
next prev parent reply other threads:[~2009-12-16 18:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 8:08 [PATCH 00/14] kernel.h cleanups Joe Perches
2009-12-16 8:09 ` [PATCH 01/14] kernel.h: Consolidate console and logging functions and defines Joe Perches
2009-12-16 8:09 ` [PATCH 02/14] kernel.h: Checkpatch cleaning Joe Perches
2009-12-16 8:09 ` [PATCH 03/14] kernel.h: ARRAY_SIZE neatening Joe Perches
2009-12-16 8:09 ` [PATCH 04/14] kernel.h: Add argument names to strtoXX, Xscanf prototypes Joe Perches
2009-12-16 8:09 ` [PATCH 05/14] kernel.h: printk neatening Joe Perches
2009-12-16 8:09 ` [PATCH 06/14] drivers/firmware/iscsi_ibft.c: Use %pI4 to print netmask Joe Perches
2009-12-16 8:09 ` [PATCH 07/14] kernel.h: Move NIPQUAD and NIPQUAD_FMT to in.h Joe Perches
2009-12-16 8:09 ` [PATCH 08/14] kernel.h: Group math and limits functions, indent function args Joe Perches
2009-12-16 8:09 ` [PATCH 09/14] kernel.h: Don't use NORET_AND just use noreturn, instead Joe Perches
2009-12-16 8:09 ` [PATCH 10/14] kernel.h: Remove ATTRIB_NORET, use __attribute__((noreturn)) Joe Perches
2009-12-16 8:09 ` [PATCH 11/14] kernel.h: Remove uses of NORET_TYPE Joe Perches
2009-12-16 8:09 ` [PATCH 12/14] kernel.h: Add pr_<level>_once Joe Perches
2009-12-16 8:09 ` [PATCH 13/14] kernel.h: Kernel address utility aggregation and other neatening Joe Perches
2009-12-16 8:09 ` [PATCH 14/14] kernel/exit.c and kernel/panic.c: Remove unused NORET_TYPE Joe Perches
2009-12-16 18:51 ` Peter Zijlstra [this message]
2009-12-16 18:53 ` Peter Zijlstra
2009-12-17 20:52 ` [PATCH 00/14] kernel.h cleanups Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1260989515.21028.228.camel@laptop \
--to=peterz@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox