public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: linux-kernel@vger.kernel.org, jens.axboe@oracle.com
Cc: nauman@google.com, lizf@cn.fujitsu.com, ryov@valinux.co.jp,
	fernando@oss.ntt.co.jp, taka@valinux.co.jp,
	guijianfeng@cn.fujitsu.com, jmoyer@redhat.com,
	m-ikeda@ds.jp.nec.com, vgoyal@redhat.com, czoccolo@gmail.com,
	Alan.Brunelle@hp.com
Subject: [PATCH 2/4] cfq-iosched: Get rid of nr_groups
Date: Wed, 16 Dec 2009 17:52:58 -0500	[thread overview]
Message-ID: <1261003980-10115-3-git-send-email-vgoyal@redhat.com> (raw)
In-Reply-To: <1261003980-10115-1-git-send-email-vgoyal@redhat.com>

o Currently code does not seem to be using cfqd->nr_groups. Get rid of it.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
 block/cfq-iosched.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index a0e5347..d9bfa09 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -208,8 +208,6 @@ struct cfq_data {
 	/* Root service tree for cfq_groups */
 	struct cfq_rb_root grp_service_tree;
 	struct cfq_group root_group;
-	/* Number of active cfq groups on group service tree */
-	int nr_groups;
 
 	/*
 	 * The priority currently being served
@@ -842,7 +840,6 @@ cfq_group_service_tree_add(struct cfq_data *cfqd, struct cfq_group *cfqg)
 
 	__cfq_group_service_tree_add(st, cfqg);
 	cfqg->on_st = true;
-	cfqd->nr_groups++;
 	st->total_weight += cfqg->weight;
 }
 
@@ -863,7 +860,6 @@ cfq_group_service_tree_del(struct cfq_data *cfqd, struct cfq_group *cfqg)
 
 	cfq_log_cfqg(cfqd, cfqg, "del_from_rr group");
 	cfqg->on_st = false;
-	cfqd->nr_groups--;
 	st->total_weight -= cfqg->weight;
 	if (!RB_EMPTY_NODE(&cfqg->rb_node))
 		cfq_rb_erase(&cfqg->rb_node, st);
-- 
1.6.2.5


  parent reply	other threads:[~2009-12-16 22:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-16 22:52 [RFC] CFQ group scheduling structure organization Vivek Goyal
2009-12-16 22:52 ` [PATCH 1/4] cfq-iosced: Remove the check for same cfq group from allow_merge Vivek Goyal
2009-12-17  9:26   ` Gui Jianfeng
2009-12-16 22:52 ` Vivek Goyal [this message]
2009-12-17  9:26   ` [PATCH 2/4] cfq-iosched: Get rid of nr_groups Gui Jianfeng
2009-12-16 22:52 ` [PATCH 3/4] cfq-iosched: Remove prio_change logic for workload selection Vivek Goyal
2009-12-17  9:20   ` Gui Jianfeng
2009-12-18 15:17     ` Vivek Goyal
2009-12-20  4:19       ` Gui Jianfeng
2009-12-17 11:49   ` Corrado Zoccolo
2009-12-16 22:53 ` [PATCH 4/4] cfq-iosched: Implement system wide RT and IDLE groups Vivek Goyal
2009-12-16 23:14 ` [RFC] CFQ group scheduling structure organization Nauman Rafique
2009-12-16 23:24   ` Vivek Goyal
2009-12-17 10:17 ` Gui Jianfeng
2009-12-18 15:21   ` Vivek Goyal
2009-12-17 11:41 ` Corrado Zoccolo
2009-12-17 23:58   ` Munehiro Ikeda
2009-12-18 16:01     ` Vivek Goyal
2009-12-21 12:16     ` Jens Axboe
2009-12-21 14:42       ` Vivek Goyal
2009-12-18 15:49   ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1261003980-10115-3-git-send-email-vgoyal@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=Alan.Brunelle@hp.com \
    --cc=czoccolo@gmail.com \
    --cc=fernando@oss.ntt.co.jp \
    --cc=guijianfeng@cn.fujitsu.com \
    --cc=jens.axboe@oracle.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=m-ikeda@ds.jp.nec.com \
    --cc=nauman@google.com \
    --cc=ryov@valinux.co.jp \
    --cc=taka@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox