From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Randy Dunlap <randy.dunlap@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH -next] nfs: fix ISO C90 warning
Date: Thu, 17 Dec 2009 16:58:13 -0500 [thread overview]
Message-ID: <1261087093.4080.36.camel@localhost> (raw)
In-Reply-To: <2375c9f90912170200m12a5310cg90343c5c1081fbb8@mail.gmail.com>
On Thu, 2009-12-17 at 18:00 +0800, Américo Wang wrote:
> Hi,
> Check that currently all usages of RPC_DEBUG are the same,
> we can replace them all.
>
> What do you think about the attached patch?
>
> Sorry for attaching it, I have a bad mail environment here.
>
> Signed-off-by: WANG Cong <xiyou.wangcong@gmail.com>
Doesn't that approach instead lead to a lot of 'unreferenced variable'
warnings in the '#undef RPC_DEBUG' case?
Cheers
Trond
prev parent reply other threads:[~2009-12-17 21:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 5:53 linux-next: Tree for December 15 Stephen Rothwell
2009-12-16 22:23 ` [PATCH -next] nfs: fix ISO C90 warning Randy Dunlap
2009-12-16 22:40 ` Trond Myklebust
2009-12-16 22:47 ` Randy Dunlap
2009-12-16 22:58 ` Thomas Gleixner
2009-12-16 23:01 ` Trond Myklebust
2009-12-17 10:00 ` Américo Wang
2009-12-17 21:58 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261087093.4080.36.camel@localhost \
--to=trond.myklebust@fys.uio.no \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox