public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] perf tools: Prevent from BITS_PER_LONG redefinition
Date: Sat, 19 Dec 2009 10:26:07 +0100	[thread overview]
Message-ID: <1261214767.20899.697.camel@laptop> (raw)
In-Reply-To: <1261173920-11320-1-git-send-regression-fweisbec@gmail.com>

On Fri, 2009-12-18 at 23:05 +0100, Frederic Weisbecker wrote:
> +#ifndef BITS_PER_LONG
>  /* CHECKME: Not sure both always match */
>  #define BITS_PER_LONG  __WORDSIZE
> +#endif 

Why use __WORDSIZE if you're not sure?

(8*sizeof(long)) is simple and unambiguous.


  reply	other threads:[~2009-12-19  9:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-18 22:05 [PATCH] perf tools: Prevent from BITS_PER_LONG redefinition Frederic Weisbecker
2009-12-19  9:26 ` Peter Zijlstra [this message]
2009-12-19 14:34   ` Frederic Weisbecker
2009-12-20  5:11     ` Jeremy Fitzhardinge
2009-12-30 21:45       ` Frederic Weisbecker
2009-12-31 11:09         ` Jeremy Fitzhardinge
2010-01-02 17:01           ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1261214767.20899.697.camel@laptop \
    --to=peterz@infradead.org \
    --cc=acme@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox