From: Peter Zijlstra <peterz@infradead.org>
To: San Mehat <san@google.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Arjan van de Ven <arjan@infradead.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: sched: restore sanity
Date: Sun, 20 Dec 2009 16:19:47 +0100 [thread overview]
Message-ID: <1261322387.4314.22.camel@laptop> (raw)
In-Reply-To: <236ccac0912200705i369d00d1v42603a00e92039b6@mail.gmail.com>
On Sun, 2009-12-20 at 07:05 -0800, San Mehat wrote:
> >> Probably, but the rest is just as annoying, pr_* is crap.
> Oh? Out of curiosity whats wrong with it?
That's what should be asked of printk().
And as long as we're not going to depricate printk() -- any attempt
thereof will meet with fierce resistance from yours truly -- its all a
futile exercise at best, and breaking scripts habits and patches at
worst.
I might be strange, but if I want to print something in C I write
print[fk]() and be done with it, there's no reason what so ever to
introduce fancy wankery for this.
We try to stick to ANSI-C as much as possible, we've got
kalloc,kfree,strcmp,strnlen and all the other 'regular' C bits,
deviating from that serves no purpose but seed confusion.
If driver folks feel the need for dumb-ass wrappers because they can't
write printk() then maybe, otoh if they can't do that, then wtf are they
doing writing drivers anyway.
But I feel this has no place in the core kernel at all, esp when its
getting in the way of things without offering a single benefit.
next prev parent reply other threads:[~2009-12-20 15:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 13:23 sched: restore sanity Peter Zijlstra
2009-12-20 14:27 ` Arjan van de Ven
2009-12-20 14:49 ` Ingo Molnar
2009-12-20 14:51 ` Peter Zijlstra
[not found] ` <236ccac0912200703g464912b1r421497ebf3b6ebc6@mail.gmail.com>
2009-12-20 15:05 ` San Mehat
2009-12-20 15:19 ` Peter Zijlstra [this message]
2009-12-20 15:28 ` Mike Galbraith
2009-12-20 15:36 ` San Mehat
2009-12-20 17:22 ` Joe Perches
2009-12-20 17:36 ` Peter Zijlstra
2009-12-20 17:50 ` Ingo Molnar
2009-12-20 17:57 ` Joe Perches
2009-12-20 17:37 ` Ingo Molnar
2009-12-20 18:17 ` Arjan van de Ven
2009-12-20 18:21 ` Joe Perches
2009-12-21 0:48 ` Arjan van de Ven
2009-12-21 1:20 ` Joe Perches
2009-12-22 10:11 ` Al Viro
2009-12-20 17:22 ` Joe Perches
2009-12-20 18:00 ` [tip:sched/urgent] sched: Restore printk sanity tip-bot for Peter Zijlstra
2009-12-20 20:36 ` Geert Uytterhoeven
2009-12-21 20:40 ` Valdis.Kletnieks
2009-12-25 13:26 ` Pavel Machek
2009-12-25 18:45 ` Ingo Molnar
2009-12-27 0:45 ` Valdis.Kletnieks
2009-12-27 5:56 ` Ingo Molnar
[not found] ` <1261756819.4937.216.camel@laptop>
2009-12-25 18:39 ` Joe Perches
2009-12-25 18:47 ` Pavel Machek
2009-12-20 18:06 ` tip-bot for Peter Zijlstra
2009-12-20 18:55 ` Joe Perches
2009-12-20 19:15 ` Ingo Molnar
2009-12-20 19:44 ` [PATCH] scripts/checkpatch.pl: Add WARN on printk format split on multiple lines Joe Perches
2009-12-20 20:10 ` Ingo Molnar
2009-12-20 22:12 ` [tip:sched/urgent] sched: Restore printk sanity tytso
2009-12-21 1:11 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261322387.4314.22.camel@laptop \
--to=peterz@infradead.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=san@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox