public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Takashi Iwai <tiwai@suse.de>, Xiaotian Feng <xtfeng@gmail.com>,
	Amerigo Wang <amwang@redhat.com>,
	linux-kernel@vger.kernel.org,
	Corentin Chary <corentincj@iksaif.net>,
	ibm-acpi-devel@lists.sourceforge.net,
	Len Brown <len.brown@intel.com>,
	Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
	akpm@linux-foundation.org, helight.xu@gmail.com
Subject: Re: [Patch] thinkpad_acpi: fix a build error
Date: Mon, 21 Dec 2009 14:38:56 -0800	[thread overview]
Message-ID: <1261435136.4041.152.camel@localhost.localdomain> (raw)
In-Reply-To: <20091218142815.GB15898@khazad-dum.debian.net>

Hi Henrique,

> > The patch isn't correct (I guess the upstream fix is same?).
> > 
> > CONFIG_SOUND is a global config for sound subsystem.  The relevant
> > functions are ALSA core part, which is CONFIG_SND.
> > So, the fix should be:
> > 
> > 	depends on SND
> > 
> > instead.
> 
> Indeed.  Ingo already fixed that too.
> 
> Although I personally would prefer:
> select SOUND
> select SND
> 
> But anything that stops the build errors will do for now.

I still haven't seen this patch in Linus' tree. And you do need select
SOUND and SND. Otherwise you still get build errors. I have tested this
on my machine. So can someone please submit a proper patch to get this
fixed.

Regards

Marcel



  parent reply	other threads:[~2009-12-21 22:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-18  9:28 [Patch] thinkpad_acpi: fix a build error Amerigo Wang
2009-12-18  9:42 ` Xiaotian Feng
2009-12-18 10:15   ` Takashi Iwai
2009-12-18 12:23     ` Helight.Xu
2009-12-18 14:28     ` Henrique de Moraes Holschuh
2009-12-18 14:31       ` Takashi Iwai
2009-12-18 15:03         ` Henrique de Moraes Holschuh
2009-12-18 15:10           ` Takashi Iwai
2009-12-21 22:38       ` Marcel Holtmann [this message]
2009-12-21 22:44         ` Randy Dunlap
2009-12-22 19:38           ` Henrique de Moraes Holschuh
2009-12-23  6:41             ` Takashi Iwai
2009-12-24 18:59               ` Henrique de Moraes Holschuh
2009-12-25 11:09                 ` Takashi Iwai
2009-12-25 13:41                   ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2009-12-25 18:39                     ` Randy Dunlap
2009-12-22  1:10         ` Helight.Xu
2009-12-22  3:00           ` Marcel Holtmann
  -- strict thread matches above, loose matches on Subject: below --
2009-12-18 13:23 [PATCH] " Helight.Xu
2009-12-18 13:28 ` Helight.Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1261435136.4041.152.camel@localhost.localdomain \
    --to=marcel@holtmann.org \
    --cc=akpm@linux-foundation.org \
    --cc=alan-jenkins@tuffmail.co.uk \
    --cc=amwang@redhat.com \
    --cc=corentincj@iksaif.net \
    --cc=helight.xu@gmail.com \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    --cc=xtfeng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox