From: john stultz <johnstul@us.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Greg Ungerer <gerg@snapgear.com>, Greg Ungerer <gerg@uclinux.org>,
Andrew Morton <akpm@linux-foundation.org>,
Steven King <sfking@fdwdc.com>
Subject: [PATCH] m68knommu: Fix invalid flags on coldfire pit clocksource
Date: Mon, 21 Dec 2009 16:39:18 -0800 [thread overview]
Message-ID: <1261442358.5293.50.camel@localhost.localdomain> (raw)
In-Reply-To: <200912181920.12905.sfking@fdwdc.com>
Just re-sending this in case it was missed. Steven tested this and it
seems to be the right fix. Should be 2.6.33 material.
thanks
-john
The m68knommu coldfire pit clocksource looks like it was incorrectly
marked as a continuous clocksource. Running with it marked as a
continuous clocksource could cause hangs when the system switches to
highres mode or enables nohz.
This patch removes the CLOCK_SOURCE_IS_CONTINUOUS flag on the coldfire
pit clocksource. This will disallow systems using this clocksource from
entering oneshot mode (disabling highres timers and nohz).
Signed-off-by: John Stultz <johnstul@us.ibm.com>
---
diff --git a/arch/m68knommu/platform/coldfire/pit.c b/arch/m68knommu/platform/coldfire/pit.c
index d8720ee..aebea19 100644
--- a/arch/m68knommu/platform/coldfire/pit.c
+++ b/arch/m68knommu/platform/coldfire/pit.c
@@ -146,7 +146,6 @@ static struct clocksource pit_clk = {
.read = pit_read_clk,
.shift = 20,
.mask = CLOCKSOURCE_MASK(32),
- .flags = CLOCK_SOURCE_IS_CONTINUOUS,
};
/***************************************************************************/
prev parent reply other threads:[~2009-12-22 0:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 2:13 2.6.33-rc1: hrtimers and tickless broken on m68knommu Steven King
2009-12-19 2:44 ` john stultz
2009-12-19 3:20 ` Steven King
2009-12-19 4:04 ` john stultz
2009-12-19 5:06 ` Steven King
2010-01-11 3:38 ` Greg Ungerer
2009-12-22 0:39 ` john stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261442358.5293.50.camel@localhost.localdomain \
--to=johnstul@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfking@fdwdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox