Re: [PATCH] perf lock: Implement basic sorting function of perf lock

Hitoshi Mitake
2010-01-08T08:02:44Z

On 2009年12月28日 19:17, Peter Zijlstra wrote:
> On Sun, 2009-12-20 at 11:56 +0900, Hitoshi Mitake wrote:
>> +/* based on kernel/lockdep.c */
>> +#define MAX_LOCKDEP_KEYS_BITS 13
>> +#define LOCKHASH_BITS (MAX_LOCKDEP_KEYS_BITS - 1)
>> +#define LOCKHASH_SIZE (1UL<< LOCKHASH_BITS)
>
> Since you're hashing something fundamentally different than lockdep does
> I don't think it makes sense to carry either the name or the size along.
>
>

Do you mean that MAX_LOCKDEP_KEYS_BITS is needless?
# Sorry, I'm not good at English...