From: Peter Zijlstra <peterz@infradead.org>
To: Simon Kagstrom <simon.kagstrom@netinsight.net>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, mingo@elte.hu,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/urgent] sched: might_sleep(): Make file parameter const char *
Date: Mon, 04 Jan 2010 11:36:25 +0100 [thread overview]
Message-ID: <1262601385.6408.115.camel@laptop> (raw)
In-Reply-To: <20100104104904.65f57a24@marrow.netinsight.se>
On Mon, 2010-01-04 at 10:49 +0100, Simon Kagstrom wrote:
> (Back from vacation, hence the delayed response)
>
> On Tue, 29 Dec 2009 13:11:48 +0100
> Peter Zijlstra <peterz@infradead.org> wrote:
>
> > On Mon, 2009-12-28 at 10:10 +0000, tip-bot for Simon Kagstrom wrote:
> >
> > > Fixes a warning when building with g++:
> >
> > However did you manage to build stuff with g++? The kernel very
> > frequently uses C++ keywords for other things.
>
> I expected this question :-)
>
> Yes, there are some workarounds we have to make to get it compiling
> (like #define new NEW prior to including the headers), but it works
> out. I know this is something you shouldn't do, and I debated whether
> to mention C++ at all.
>
>
> Anyway, I think the change itself makes sense for plain C as well. The
> comment just described the context where it showed up for us.
Oh sure, the change is fine, just wondering what specific drug you were
using as it was not the regular kernel kind ;-)
prev parent reply other threads:[~2010-01-04 10:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 10:08 [PATCH/trivial] might_sleep: Make file parameter const char * Simon Kagstrom
2009-12-28 10:10 ` [tip:sched/urgent] sched: might_sleep(): " tip-bot for Simon Kagstrom
2009-12-29 12:11 ` Peter Zijlstra
2009-12-30 9:25 ` Ingo Molnar
2010-01-04 9:49 ` Simon Kagstrom
2010-01-04 10:36 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262601385.6408.115.camel@laptop \
--to=peterz@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=simon.kagstrom@netinsight.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox