From: Stefani Seibold <stefani@seibold.net>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
apw@canonical.com, jschopp@austin.ibm.com, davej@redhat.com
Subject: [PATCH] checkpatch.pl: remove the punch card limit
Date: Wed, 06 Jan 2010 17:56:24 +0100 [thread overview]
Message-ID: <1262796984.1011.17.camel@wall-e> (raw)
The time of 80 characters punch card and terminals are over, so i would
be a good thing to set the line length limit to 120. Every display today
should be able handle this. And it think it make formated source code
more readable.
For everybody who want know: The 80 column limit of a terminal comes
from the punch cards, which stored exact 80 characters.
Signed-off-by: Stefani Seibold <stefani@seibold.net>
---
checkpatch.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.33-rc2.orig/scripts/checkpatch.pl 2009-12-03 04:51:21.000000000 +0100
+++ linux-2.6.33-rc2.new/scripts/checkpatch.pl 2010-01-06 17:46:40.057565661 +0100
@@ -1374,13 +1374,13 @@ sub process {
# check we are in a valid source file if not then ignore this hunk
next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
-#80 column limit
+#120 column limit
if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
$rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
$line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
- $length > 80)
+ $length > 120)
{
- WARN("line over 80 characters\n" . $herecurr);
+ WARN("line over 120 characters\n" . $herecurr);
}
# check for adding lines without a newline.
next reply other threads:[~2010-01-06 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 16:56 Stefani Seibold [this message]
2010-01-07 3:07 ` [PATCH] checkpatch.pl: remove the punch card limit Miles Bader
2010-01-07 7:31 ` Stefani Seibold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262796984.1011.17.camel@wall-e \
--to=stefani@seibold.net \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=davej@redhat.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox