From: Artem Bityutskiy <dedekind1@gmail.com>
To: "René Bolldorf" <xsecute@googlemail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH]drivers/mtd/chips/cfi_probe.c:18 remove unneeded comment
Date: Wed, 13 Jan 2010 07:32:45 +0200 [thread overview]
Message-ID: <1263360765.3445.13.camel@localhost.localdomain> (raw)
In-Reply-To: <4B465DA1.6010300@googlemail.com>
On Thu, 2010-01-07 at 23:18 +0100, René Bolldorf wrote:
> --- ./drivers/mtd/chips/cfi_probe.c 2009-12-28 21:09:46.638828686 +0100
> +++ ./drivers/mtd/chips/cfi_probe.c 2010-01-04 22:38:31.536678726 +0100
> @@ -18,8 +18,6 @@
> #include <linux/mtd/cfi.h>
> #include <linux/mtd/gen_probe.h>
>
> -//#define DEBUG_CFI
> -
> #ifdef DEBUG_CFI
> static void print_cfi_ident(struct cfi_ident *);
> #endif
I do not think this is is needed. The commented out define shows what
one should do to debug the thing. Without that line it is not so
obvious. So, nack from me.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2010-01-13 5:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 22:18 [PATCH]drivers/mtd/chips/cfi_probe.c:18 remove unneeded comment René Bolldorf
2010-01-13 5:32 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263360765.3445.13.camel@localhost.localdomain \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=xsecute@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox